From 17766010212417a87ea7728190cd0c7f6a2873dd Mon Sep 17 00:00:00 2001 From: zrh122 <1229550935@qq.com> Date: Wed, 12 Jun 2019 11:59:45 +0800 Subject: [PATCH 1/2] chore(test): remove useless code and comments --- test/e2e/runner.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/e2e/runner.js b/test/e2e/runner.js index e0167e08b..5f7fa8ad5 100644 --- a/test/e2e/runner.js +++ b/test/e2e/runner.js @@ -36,8 +36,7 @@ const NW_CONFIG = isLocal ? resolve(__dirname, './nightwatch.browserstack.js') : resolve(__dirname, './nightwatch.config.js') -// add a configuration by default if not provided -// add a configuration by default if not provided +// check configuration if (args.indexOf('-c') < 0) { // check if multiple envs are provided. The way Nightwatch works // requires to explicitely provide the conf @@ -50,7 +49,6 @@ if (args.indexOf('-c') < 0) { ) process.exit(1) } - args.push('-c', NW_CONFIG) } else if (isLocal) { const conf = args[args.indexOf('-c') + 1] if (resolve('.', conf) !== NW_CONFIG) { From 28f6ec0dd1f176a9f2a7c4c73cbea428abfeb2f8 Mon Sep 17 00:00:00 2001 From: Eduardo San Martin Morote Date: Fri, 23 Aug 2019 19:26:10 +0200 Subject: [PATCH 2/2] chore: comment --- test/e2e/runner.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/runner.js b/test/e2e/runner.js index 5f7fa8ad5..bc2dbc418 100644 --- a/test/e2e/runner.js +++ b/test/e2e/runner.js @@ -36,7 +36,7 @@ const NW_CONFIG = isLocal ? resolve(__dirname, './nightwatch.browserstack.js') : resolve(__dirname, './nightwatch.config.js') -// check configuration +// check -c option is passed when usig multiple environments if (args.indexOf('-c') < 0) { // check if multiple envs are provided. The way Nightwatch works // requires to explicitely provide the conf