Skip to content

Parent link loses active class #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abellion opened this issue May 9, 2019 · 3 comments
Closed

Parent link loses active class #2765

abellion opened this issue May 9, 2019 · 3 comments

Comments

@abellion
Copy link

abellion commented May 9, 2019

Version

3.0.3

Reproduction link

https://jsfiddle.net/ve3cwk0h/3/

Steps to reproduce

I havent' been able to reproduce the issue, but I noticed it appears from V3.0.3 (everything works in V3.0.2). So it must have appeared in one of these commits :

What is expected?

Giving two routes, /a and /a/b, the /a link should have the active class when navigating on /a/b.

What is actually happening?

It doesn't happen for all the links but only some of them, for example if I have a parent /a and two children /a/1 and /a/2, the parent has the active class on /a/1 but loses it when navigating on /a/2.

@posva
Copy link
Member

posva commented May 9, 2019

If you cannot reproduce it, I cannot take a look at it...

@posva posva closed this as completed May 9, 2019
@abellion
Copy link
Author

abellion commented May 9, 2019

Hey @posva, I've finally been able to reproduce the issue : https://codesandbox.io/embed/54lv0m251k

There is three links :

  • Settings /settings
  • Modules /settings/modules
  • Onboarding /settings/onboarding

Settings should be highlighted when navigating on Onboarding but that's not the case. Works well on Modules.

@posva
Copy link
Member

posva commented May 9, 2019

See #2717 and #2724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants