Skip to content

How to maximize the reuse of code in beforeRouteEnter and beforeRouteUpdate #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubyLiuqq opened this issue Mar 19, 2018 · 2 comments
Closed

Comments

@rubyLiuqq
Copy link

Version
3.0.1

Reproduction link
https://github.com/vuejs/vue-router/blob/dev/src/util/push-state.js#L44

Steps to reproduce
Run application into iframe

What is expected?
Please, add the way to setup window.top in VueRouter

What is actually happening?
const history = window.history
is used
should be way to use
const history = window.top.history
via some flag

@vue-bot
Copy link

vue-bot commented Mar 19, 2018

Hello, your issue has been closed because it does not conform to our issue requirements. In order to ensure every issue provides the necessary information for us to investigate, we require the use of the Issue Helper when creating new issues. Thank you!

@vue-bot vue-bot closed this as completed Mar 19, 2018
@rubyLiuqq rubyLiuqq changed the title How to maximize the reuse of code in beforeRouteEnter and beforeRouteUpdate How Mar 19, 2018
@rubyLiuqq rubyLiuqq changed the title How How to maximize the reuse of code in beforeRouteEnter and beforeRouteUpdate Mar 19, 2018
@rubyLiuqq
Copy link
Author

rubyLiuqq commented Mar 19, 2018

To see #1582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants