From c2899b8e502a5f15972aa2676cfe0fa8e74b2025 Mon Sep 17 00:00:00 2001 From: Ismo Vuorinen Date: Thu, 28 Feb 2019 19:01:29 +0200 Subject: [PATCH] Extended Vue and Vuex version checks from Vue v2 to v9 and Vuex v1 to v9 --- rules/vue/vue-dependency.js | 2 +- rules/vue/vue-dependency.spec.js | 14 ++++++++++++++ rules/vuex/vuex-dependency.js | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/rules/vue/vue-dependency.js b/rules/vue/vue-dependency.js index 22cf815..70b59fb 100644 --- a/rules/vue/vue-dependency.js +++ b/rules/vue/vue-dependency.js @@ -3,7 +3,7 @@ var chalk = require('chalk') module.exports = { - pattern: /("vue"\s*:\s*)"[^\d"]*?[^2]\.\d+\.\d+"/, + pattern: /("vue"\s*:\s*)"[^\d"]*?[^2-9]\.\d+\.\d+"/, warning: function (match, preVersion) { return { reason: 'If you are using pre-2.0 Vue through NPM, you have to update it in your package.json file', diff --git a/rules/vue/vue-dependency.spec.js b/rules/vue/vue-dependency.spec.js index 017f470..9235b8e 100644 --- a/rules/vue/vue-dependency.spec.js +++ b/rules/vue/vue-dependency.spec.js @@ -36,6 +36,20 @@ describe('Rule: vue-dependency', () => { expect(warning).toBe(null) }) + it('is not limited to pre 3.0 versions', () => { + const warning = check(` + "vue": "3.0.0" + `) + expect(warning).toBe(null) + }) + + it('is not limited to pre 3.0 versions, with comma', () => { + const warning = check(` + "vue": "3.0.0", + `) + expect(warning).toBe(null) + }) + it('does not match vuex "1.0.0"', () => { const warning = check(` "vuex": "1.0.0" diff --git a/rules/vuex/vuex-dependency.js b/rules/vuex/vuex-dependency.js index cec4c1c..965ee73 100644 --- a/rules/vuex/vuex-dependency.js +++ b/rules/vuex/vuex-dependency.js @@ -3,7 +3,7 @@ var chalk = require('chalk') module.exports = { - pattern: /("vuex"\s*:\s*)"[^\d"]*?[^1-2]\.\d+\.\d+"/, + pattern: /("vuex"\s*:\s*)"[^\d"]*?[^1-9]\.\d+\.\d+"/, warning: function (match, preVersion) { return { reason: 'Vuex 1.0 is the earliest supported version compatible with Vue 2.0',