Package version constraint parsing seems off

[ivuorinen]

Running vue-migration-helper with vue-router:^3.0.2 and vuex:^3.0.1 suggests following migrations:

1. Replace "vue-router": "^3.0.2" with "vue-router": "^2.0.0", then run: npm install
  Line 22: package.json
  Reason: If you are using pre-2.0 Vue Router through NPM, you have to update it in your package.json file
  More info: http://vuejs.org/guide/migration-vue-router.html#

2. Replace "vuex": "^3.1.0" with "vuex": "^1.0.0", then run: npm install
  Line 23: package.json
  Reason: Vuex 1.0 is the earliest supported version compatible with Vue 2.0
  More info: http://vuejs.org/guide/migration-vuex.html#

It looks like the check assumes anything that's not 2.* (for vue-router) is wrong:

• vue-migration-helper/rules/vue-router/vue-router-dependency.js

  Line 6 in 3dc64a9

  pattern: /("vue-router"\s*:\s*)"[^\d"]*?[^2]\.\d+\.\d+"/,

• vue-migration-helper/rules/vuex/vuex-dependency.js

  Line 6 in 3dc64a9

  pattern: /("vuex"\s*:\s*)"[^\d"]*?[^1-2]\.\d+\.\d+"/,

Should/Could it be changed to use semver.satisfies('^2.0.0', [package.json data]) and ^1.0.0?

[chrisvfritz]

Thanks for reporting this. 🙂 The way the matching works here, we'd have to stick with regex rather than the more optimal semver.satisfies, but a PR with a fix and new tests would be very welcome for this! Otherwise, I'll try to get to it as soon as I'm able.

[ivuorinen]

Closing as resolved, thanks for accepting the PR!

[chrisvfritz]

Thanks for providing it! 🙂