Skip to content

Better detection within Laravel's .blade.php files #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrandonSurowiec opened this issue Oct 1, 2016 · 5 comments
Open

Better detection within Laravel's .blade.php files #14

BrandonSurowiec opened this issue Oct 1, 2016 · 5 comments

Comments

@BrandonSurowiec
Copy link

BrandonSurowiec commented Oct 1, 2016

I ran the migration helper on a project and it is falsely detecting "Interpolation within attributes" for blade files within a Laravel project.

It thinks href="{{ $url }}" should be :href="$url"

I have to write it like href="@{{ url }}" for Vue. :)

@chrisvfritz
Copy link
Contributor

I'd be open to eventually adding options, such as --interpolation-delimiter-start and --interpolation-delimiter-end. I want to finish the Vue Router rules before starting on something like that though.

@BrandonSurowiec
Copy link
Author

BrandonSurowiec commented Oct 1, 2016

@chrisvfritz Is there a way to simply dump the output to a .txt/.log file? I can sort through the false positives easier. That solution would be good enough for me.

@chrisvfritz
Copy link
Contributor

@BrandonSurowiec Definitely! I'm not sure if this works on Windows, but on OS X and Linux, you can run something like:

vue-migration-helper src > migration-warnings.log

@BrandonSurowiec
Copy link
Author

Perfect! It works on Windows and allows me to sort through it easier. Thank you!

@masonfox
Copy link

masonfox commented Nov 3, 2016

This would be a huge help! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants