prevent router lifecycle hooks matching embedded text with parentheses

Author: chrisvfritz

rules/vue-router/router-lifecycle-data.js

@@ -3,7 +3,7 @@
 var chalk = require('chalk')
 
 module.exports = {
-  pattern: /\bdata\s*?(?::\s*\(?\s*[\w,\s]+\)?\s*=>|\(\s*\w+)/,
+  pattern: /^\s*data\s*?(?::\s*\(?\s*[\w,\s]+\)?\s*=>|\(\s*\w+)/,
   warning: function (match, hook) {
     return {
       reason: 'The data route lifecycle hook has been deprecated',

rules/vue-router/router-lifecycle-data.spec.js

@@ -57,6 +57,13 @@ describe('Rule: router-lifecycle-data', () => {
     expect(warning).toBe(null)
   })
 
+  it('does not match activate in text with parentheses after it', () => {
+    const warning = check(`
+      blah blah data (blah blah)
+    `)
+    expect(warning).toBe(null)
+  })
+
   it('matches data with ES2015 arrow function and one argument', () => {
     const warning = check(`
       data: foo => {

rules/vue-router/router-lifecycle-hooks.js

@@ -18,7 +18,7 @@ const extraInfo = {
 
 module.exports = {
   pattern: new RegExp(
-    '\\b(' +
+    '^\\s*(' +
     Object.keys(hookReplacements).join('|') +
     ')\\s*?(?::|\\()'
   ),

rules/vue-router/router-lifecycle-hooks.spec.js

@@ -13,6 +13,18 @@ describe('Rule: router-lifecycle-hooks', () => {
     expect(warning).toBe(null)
   })
 
+  it('does not match activated:', () => {
+    const warning = check('activated:')
+    expect(warning).toBe(null)
+  })
+
+  it('does not match data in text with parentheses after it', () => {
+    const warning = check(`
+      blah blah activate (blah blah)
+    `)
+    expect(warning).toBe(null)
+  })
+
   it('matches activate with ES5 function', () => {
     const warning = check(`
       activate: function () {