Skip to content

Commit b31f322

Browse files
committed
extract parent folder name matcher to its own module and add tests
1 parent c52f639 commit b31f322

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

helpers/parent-folder-name-for.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
module.exports = function (file) {
2+
return file.match(/([^\/\\]+)[\/\\][^\/\\]+\.js/)[1]
3+
}
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
'use strict'
2+
3+
const getParentFolderName = require('./parent-folder-name-for')
4+
5+
describe('Helper: parent-folder-name-for', () => {
6+
it('returns the main migration guide for vue', () => {
7+
expect(
8+
getParentFolderName('/Users/fritzc/code/vue-migration-helper/rules/vue/array-prototype-remove.js')
9+
).toBe('vue')
10+
})
11+
12+
it('returns the main migration guide for vue', () => {
13+
expect(
14+
getParentFolderName('C:\\Users\\fuis\\AppData\\Roaming\\npm\\node_modules\\vue-migration-helper\\rules\\vue\\array-prototype-remove.js')
15+
).toBe('vue')
16+
})
17+
})

helpers/report-warning.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,13 @@
22

33
var chalk = require('chalk')
44
var migrationGuideUrlFor = require('./migration-guide-url-for')
5+
var parentFolderNameFor = require('./parent-folder-name-for')
56

67
var warningCount = 0
78
module.exports = function (fileData, warning, rule) {
89
warningCount++
910

10-
var library = rule.file.match(/([^\/\\]+)[\/\\][^\/\\]+\.js/)[1]
11+
var library = parentFolderNameFor(rule.file)
1112

1213
console.log()
1314
console.log(chalk.yellow(

0 commit comments

Comments
 (0)