From 141875ea936c1dd5e28820ecf6f466bffafc00e1 Mon Sep 17 00:00:00 2001 From: Jinjiang Date: Tue, 14 Nov 2017 16:06:59 +0800 Subject: [PATCH 1/2] fixed #1052 --- lib/template-compiler/modules/transform-srcset.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/template-compiler/modules/transform-srcset.js b/lib/template-compiler/modules/transform-srcset.js index 49a15585b..2779eeae6 100644 --- a/lib/template-compiler/modules/transform-srcset.js +++ b/lib/template-compiler/modules/transform-srcset.js @@ -28,10 +28,15 @@ function transform (node) { return { require: urlToRequire(url), descriptor: descriptor } }) - let code = '' - imageCandidates.forEach((o, i, a) => { - code += o.require + ' + " ' + o.descriptor + (i < a.length - 1 ? ', " + ' : '"') - }) + // "require(url1)" + // "require(url1) 1x" + // "require(url1), require(url2)" + // "require(url1), require(url2) 2x" + // "require(url1) 1x, require(url2)" + // "require(url1) 1x, require(url2) 2x" + const code = imageCandidates.map( + ({ require, descriptor }) => `${require} + "${descriptor ? ' ' + descriptor : ''}, " + ` + ).join('').slice(0, -6).concat('"').replace(/ \+ ""$/, '') attr.value = code } From 77802fd4d3643014aded509e5850e4bb473996f8 Mon Sep 17 00:00:00 2001 From: Jinjiang Date: Tue, 14 Nov 2017 16:13:25 +0800 Subject: [PATCH 2/2] added test case for #1052 --- test/fixtures/transform.vue | 4 ++++ test/test.js | 11 +++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/test/fixtures/transform.vue b/test/fixtures/transform.vue index 1e358f890..f43b47c69 100644 --- a/test/fixtures/transform.vue +++ b/test/fixtures/transform.vue @@ -4,8 +4,12 @@ + + + +