Skip to content

feat: add components mousein highlight event throttle #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

process1024
Copy link

@process1024 process1024 commented Jun 16, 2022

Description

when the mouse over the component tree will trigger hight events frequently,if the compenent tree is big or deep,it would make UI slow and doesn't response.

Additional context

add components mouse-in highlight event throttle,this problem fixed.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@process1024 process1024 changed the title feat: make components mousein highlight event throttle feat: add components mousein highlight event throttle Jun 16, 2022
Akryum added a commit that referenced this pull request Sep 24, 2022
Akryum added a commit that referenced this pull request Sep 24, 2022
@Akryum
Copy link
Member

Akryum commented Sep 24, 2022

Hey! Thanks for your PR! 💚 However I went with a different implementation reusing lodash/throttle:
96a4f79

@Akryum Akryum closed this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants