Skip to content

Commit a0243bd

Browse files
committed
fix(timeline): no events empty pane not updating
1 parent 716a811 commit a0243bd

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

packages/app-frontend/src/features/timeline/TimelineEventList.vue

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export default defineComponent({
6363
const displayedEvents = computed(() => {
6464
switch (tabId.value) {
6565
case 'group':
66-
return selectedGroupEvents.value
66+
return selectedGroupEvents.value ?? []
6767
case 'all':
6868
default:
6969
return selectedLayer.value?.events ?? []
@@ -75,11 +75,6 @@ export default defineComponent({
7575
const filter = ref('')
7676
7777
const filteredEvents = computed(() => {
78-
// Prevent crash on the filteredEvents.length watcher
79-
if (!selectedEvent.value) {
80-
return []
81-
}
82-
8378
const rawFilter = filter.value.trim()
8479
if (rawFilter) {
8580
const reg = new RegExp(rawFilter, 'i')
@@ -209,12 +204,12 @@ export default defineComponent({
209204

210205
<template>
211206
<div
212-
v-if="selectedEvent && selectedLayer"
207+
v-if="selectedLayer && filteredEvents.length"
213208
class="h-full flex flex-col relative"
214209
>
215210
<div class="flex-none flex flex-col items-stretch border-gray-200 dark:border-gray-800 border-b">
216211
<VueGroup
217-
v-if="selectedEvent.group"
212+
v-if="selectedEvent && selectedEvent.group"
218213
v-model="tabId"
219214
indicator
220215
class="accent extend border-gray-200 dark:border-gray-800 border-b"

0 commit comments

Comments
 (0)