Skip to content

Switch over to leven for command suggestion #5164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamesgeorge007 opened this issue Feb 8, 2020 · 1 comment · Fixed by #5166
Closed

Switch over to leven for command suggestion #5164

jamesgeorge007 opened this issue Feb 8, 2020 · 1 comment · Fixed by #5166
Labels
enhancement has PR

Comments

@jamesgeorge007
Copy link
Contributor

What problem does this feature solve?

As of now didyoumean.js matching engine is used to suggest matching commands if the user mistypes. But it is not longer actively maintained. Instead I would suggest switching over to leven which is the fastest JS implementation of the Levenshtein distance algorithm.

What does the proposed API look like?

leven returns the distance between 2 strings which can be made use of to find the exact match.
@haoqunjiang
Copy link
Member

Good point. Go ahead please.

@jamesgeorge007 jamesgeorge007 mentioned this issue Feb 8, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: migrate to leven for command suggestion jamesgeorge007/vue-cli
3 participants
@LinusBorg @haoqunjiang @jamesgeorge007