Skip to content

Please update register-service-worker dependency #2964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
185driver opened this issue Nov 16, 2018 · 2 comments
Closed

Please update register-service-worker dependency #2964

185driver opened this issue Nov 16, 2018 · 2 comments

Comments

@185driver
Copy link

What problem does this feature solve?

Version 1.5.2 of the register-service-worker package has been released, but the version used by @vue/cli-plugin-pwa remains at '1.0.0'.

Thank you for all your work. It's much appreciated.

What does the proposed API look like?

register-service-worker

@LinusBorg
Copy link
Member

LinusBorg commented Nov 16, 2018

The required version is ^1.0.0, which means it will install the latest minor version. So you will get 1.5.2, and as long as the code that we use is compatible with 1.0.0, keeping the dependency at ^1.0.0 seems fine to me.

@185driver
Copy link
Author

Okay, np, you would know best.

My own experience is that I recently created a new app using vue cli 3 and added the pwa plugin as part of the creation process. An older "register-service-worker": "^1.0.0" was created for me in my project root's package.json "dependencies" section, which I manually updated to '^1.5.2'. But it my later observation that the pwa plugin itself used the same '^1.0.0' version, which is what triggered this submitted issue. It sure seems like only the old version is being used.

On a slightly related note (and this is not the place to request an update, I know) a more complete registerServiceWorker.js script is provided in the Usage section for that plugin, but that too is not currently being deployed with vue's pwa plugin on project creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants