Skip to content

Commit f67bc93

Browse files
committed
test: fix some tests
1 parent d9351ef commit f67bc93

File tree

2 files changed

+21
-17
lines changed

2 files changed

+21
-17
lines changed

packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js

+20-16
Original file line numberDiff line numberDiff line change
@@ -42,23 +42,27 @@ describe('nightwatch e2e plugin', () => {
4242
})
4343

4444
test('should accept the --url cli option', async () => {
45-
await project.run(`vue-cli-service build`)
46-
const server = createServer({ root: path.join(project.dir, 'dist') })
47-
await new Promise((resolve, reject) => {
48-
server.listen(8080, err => {
49-
if (err) return reject(err)
50-
resolve()
45+
let server
46+
try {
47+
await project.run(`vue-cli-service build`)
48+
server = createServer({ root: path.join(project.dir, 'dist') })
49+
await new Promise((resolve, reject) => {
50+
server.listen(8080, err => {
51+
if (err) return reject(err)
52+
resolve()
53+
})
5154
})
52-
})
53-
await project.run(`vue-cli-service test:e2e --headless --url http://127.0.0.1:8080/`)
54-
server.close()
55-
56-
let results = await project.read('test_results.json')
57-
results = JSON.parse(results)
58-
expect(Object.keys(results.modules)).toEqual([
59-
'test-with-pageobjects',
60-
'test'
61-
])
55+
await project.run(`vue-cli-service test:e2e --headless --url http://127.0.0.1:8080/`)
56+
57+
let results = await project.read('test_results.json')
58+
results = JSON.parse(results)
59+
expect(Object.keys(results.modules)).toEqual([
60+
'test-with-pageobjects',
61+
'test'
62+
])
63+
} finally {
64+
server && server.close()
65+
}
6266
})
6367

6468
test('should run single test with custom nightwatch.json', async () => {

packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,12 @@ test('should persist cache', async () => {
216216
server.stdout.on('data', data => {
217217
data = data.toString()
218218
if (data.match(/Compiled successfully/)) {
219+
server.stdin.write('close')
219220
done()
220221
}
221222
})
222223

223224
await donePromise
224-
server.kill('SIGTERM')
225225

226226
expect(has('node_modules/.cache/.eslintcache')).toBe(true)
227227
})

0 commit comments

Comments
 (0)