Skip to content

Commit b01f324

Browse files
committed
fix html escape during render
1 parent a9b3ae8 commit b01f324

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

lib/generate.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ var path = require('path')
66
var getOptions = require('./options')
77
var ask = require('./ask')
88
var filter = require('./filter')
9-
var extend = Object.assign || require('util')._extend
109

1110
// register hendlebars helper
1211
Handlebars.registerHelper('if_eq', function (a, b, opts) {
@@ -33,10 +32,10 @@ Handlebars.registerHelper('unless_eq', function (a, b, opts) {
3332
module.exports = function generate (name, src, dest, done) {
3433
var opts = getOptions(name, src)
3534
var metalsmith = Metalsmith(path.join(src, 'template'))
36-
// extract all gathered data from user and override project name with destination directory name
37-
var data = extend({}, metalsmith.metadata(), { destDirName: name })
38-
// avoid handlebars escaping HTML
39-
data.noEscape = true
35+
var data = Object.assign(metalsmith.metadata(), {
36+
destDirName: name,
37+
noEscape: true
38+
})
4039
metalsmith
4140
.use(askQuestions(opts.prompts))
4241
.use(filterFiles(opts.filters))

test/e2e/test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,14 @@ function monkeyPatchInquirer (answers) {
3131
describe('vue-cli', () => {
3232
const answers = {
3333
name: 'vue-cli-test',
34-
author: 'ziga',
34+
author: 'John Doe <[email protected]>',
3535
description: 'vue-cli e2e test',
3636
preprocessor: {
3737
less: true,
3838
sass: true
3939
},
40-
pick: 'no'
40+
pick: 'no',
41+
noEscape: true
4142
}
4243

4344
it('template generation', done => {
@@ -54,7 +55,6 @@ describe('vue-cli', () => {
5455
], function (file, next) {
5556
const template = fs.readFileSync(`${MOCK_TEMPLATE_REPO_PATH}/template/${file}`, 'utf8')
5657
const generated = fs.readFileSync(`${MOCK_TEMPLATE_BUILD_PATH}/${file}`, 'utf8')
57-
5858
render(template, answers, (err, res) => {
5959
if (err) return next(err)
6060
expect(res).to.equal(generated)

0 commit comments

Comments
 (0)