Skip to content

Commit 82aef12

Browse files
committed
test: simplify loadModule special case handling for tests
1. createRequire should have been properly handled in newer Jest versions: jestjs/jest#9469 2. We don't test migrators with Jest mock modules anymore So it's safe to skip that condition
1 parent 4e8a4ff commit 82aef12

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

packages/@vue/cli-shared-utils/lib/module.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,9 @@ exports.resolveModule = function (request, context) {
6262
}
6363

6464
exports.loadModule = function (request, context, force = false) {
65-
// createRequire doesn't work with jest mock modules
66-
// (which we used in migrator for inquirer, and in tests for cli-service)
67-
// TODO: it's supported in Jest 25
68-
if (process.env.VUE_CLI_TEST && (request.endsWith('migrator') || context === '/')) {
65+
// createRequire doesn't work with jest mocked fs
66+
// (which we used in tests for cli-service)
67+
if (process.env.VUE_CLI_TEST && context === '/') {
6968
return require(request)
7069
}
7170

0 commit comments

Comments
 (0)