fix: should not thrown on Windows when proxy target is an object

haoqunjiang · haoqunjiang · commit 5786e273b2e1 · 2018-10-22T01:17:20.000+08:00
closes #2478
diff --git a/packages/@vue/cli-service/lib/util/prepareProxy.js b/packages/@vue/cli-service/lib/util/prepareProxy.js
@@ -51,7 +51,10 @@ module.exports = function prepareProxy (proxy, appPublicFolder) {
   }
 
   function createProxyEntry (target, usersOnProxyReq, context) {
-    if (process.platform === 'win32') {
+    // #2478
+    // There're a little-known use case that the `target` field is an object rather than a string
+    // https://github.com/chimurai/http-proxy-middleware/blob/master/recipes/https.md
+    if (typeof target === 'string' && process.platform === 'win32') {
       target = resolveLoopback(target)
     }
     return {

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,10 @@ module.exports = function prepareProxy (proxy, appPublicFolder) {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`function createProxyEntry (target, usersOnProxyReq, context) {`
`54`		`- if (process.platform === 'win32') {`
	`54`	`+ // #2478`
	`55`	+ // There're a little-known use case that the `target` field is an object rather than a string
	`56`	`+ // https://github.com/chimurai/http-proxy-middleware/blob/master/recipes/https.md`
	`57`	`+ if (typeof target === 'string' && process.platform === 'win32') {`
`55`	`58`	`target = resolveLoopback(target)`
`56`	`59`	`}`
`57`	`60`	`return {`