fix(eslint-migrator): fix local eslint major version detection (#5363)

haoqunjiang · web-flow · commit 30b6873fed00 · 2020-04-07T18:54:00.000+08:00
closes #5357
diff --git a/packages/@vue/cli-plugin-eslint/migrator/index.js b/packages/@vue/cli-plugin-eslint/migrator/index.js
@@ -21,10 +21,11 @@ module.exports = async (api) => {
   }
 
   const localESLintMajor = semver.major(
-    semver.maxSatisfying(
-      ['4.99.0', '5.99.0', '6.99.0'],
-      localESLintRange
-    )
+    semver.maxSatisfying(['4.99.0', '5.99.0', '6.99.0'], localESLintRange) ||
+      // in case the user does not specify a typical caret range;
+      // it is used as **fallback** because the user may have not previously
+      // installed eslint yet, such as in the case that they are from v3.0.x
+      require('eslint/package.json').version
   )
 
   if (localESLintMajor === 6) {

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,11 @@ module.exports = async (api) => {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`const localESLintMajor = semver.major(`
`24`		`- semver.maxSatisfying(`
`25`		`- ['4.99.0', '5.99.0', '6.99.0'],`
`26`		`- localESLintRange`
`27`		`- )`
	`24`	`+ semver.maxSatisfying(['4.99.0', '5.99.0', '6.99.0'], localESLintRange) \|\|`
	`25`	`+ // in case the user does not specify a typical caret range;`
	`26`	`+ // it is used as fallback because the user may have not previously`
	`27`	`+ // installed eslint yet, such as in the case that they are from v3.0.x`
	`28`	`+ require('eslint/package.json').version`
`28`	`29`	`)`
`29`	`30`
`30`	`31`	`if (localESLintMajor === 6) {`