Skip to content

fix: fix nullable type in ts 2.6 #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2017
Merged

fix: fix nullable type in ts 2.6 #182

merged 1 commit into from
Nov 1, 2017

Conversation

HerringtonDarkholme
Copy link
Member

Fix #181

TS 2.6 seems to change Object.getOwnPropertyDescriptor

Note key is already the property name, there is no need to check null in runtime.

@ktsn
Copy link
Member

ktsn commented Nov 1, 2017

@HerringtonDarkholme Thanks! But npm run example still produce compile error as reported in the original thread like:

Type '<VC extends VueClass<Vue>>(target: VC) => VC' is not assignable to type 'typeof App'

@HerringtonDarkholme
Copy link
Member Author

That is another problem in Vuex's type definition.

@ktsn ktsn merged commit 95d9e65 into vuejs:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HerringtonDarkholme @ktsn