Skip to content

Commit d837e82

Browse files
committed
fix: don't reopen browser on restart
closes #4001
1 parent 0fc70e2 commit d837e82

File tree

1 file changed

+20
-13
lines changed

1 file changed

+20
-13
lines changed

Diff for: src/node/cli.ts

+20-13
Original file line numberDiff line numberDiff line change
@@ -28,25 +28,32 @@ if (!command || command === 'dev') {
2828
argv.optimizeDeps = { force: true }
2929
}
3030

31-
const createDevServer = async () => {
32-
const server = await createServer(root, argv, async () => {
33-
if (!restartPromise) {
34-
restartPromise = (async () => {
35-
await server.close()
36-
await createDevServer()
37-
})().finally(() => {
38-
restartPromise = undefined
39-
})
40-
}
31+
const open = argv.open
32+
delete argv.open
4133

42-
return restartPromise
43-
})
34+
const createDevServer = async (isRestart = true) => {
35+
const server = await createServer(
36+
root,
37+
!isRestart ? { ...argv, open } : argv,
38+
async () => {
39+
if (!restartPromise) {
40+
restartPromise = (async () => {
41+
await server.close()
42+
await createDevServer()
43+
})().finally(() => {
44+
restartPromise = undefined
45+
})
46+
}
47+
48+
return restartPromise
49+
}
50+
)
4451
await server.listen()
4552
logVersion(server.config.logger)
4653
server.printUrls()
4754
bindShortcuts(server, createDevServer)
4855
}
49-
createDevServer().catch((err) => {
56+
createDevServer(false).catch((err) => {
5057
createLogger().error(
5158
`${c.red(`failed to start server. error:`)}\n${err.message}\n${err.stack}`
5259
)

0 commit comments

Comments
 (0)