From b5a8d2047ff54d2e360ee6d4cbbf914fc23b2ec1 Mon Sep 17 00:00:00 2001 From: Benjamin Date: Thu, 10 May 2018 14:11:44 +0930 Subject: [PATCH 1/2] change NODE_ENV to follow recommendations from weback --- src/v2/guide/deployment.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/v2/guide/deployment.md b/src/v2/guide/deployment.md index c22c96340e..48b59bd7e8 100644 --- a/src/v2/guide/deployment.md +++ b/src/v2/guide/deployment.md @@ -36,9 +36,7 @@ module.exports = { plugins: [ // ... new webpack.DefinePlugin({ - 'process.env': { - NODE_ENV: JSON.stringify('production') - } + 'process.env.NODE_ENV': NODE_ENV: JSON.stringify('production') }) ] } From 9f6dec70b334595701964d598c693dd3b3ad7b04 Mon Sep 17 00:00:00 2001 From: Benjamin Ayles Date: Thu, 10 May 2018 14:15:43 +0930 Subject: [PATCH 2/2] Update deployment.md --- src/v2/guide/deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/v2/guide/deployment.md b/src/v2/guide/deployment.md index 48b59bd7e8..3481ccdc98 100644 --- a/src/v2/guide/deployment.md +++ b/src/v2/guide/deployment.md @@ -36,7 +36,7 @@ module.exports = { plugins: [ // ... new webpack.DefinePlugin({ - 'process.env.NODE_ENV': NODE_ENV: JSON.stringify('production') + 'process.env.NODE_ENV': JSON.stringify('production') }) ] }