Skip to content

Commit 71f1d8c

Browse files
authored
Remove Vue School Summer Sale banner (#2842)
* Remove Vue School Summer Sale banner * Remove Vue School banner images
1 parent 94192ef commit 71f1d8c

File tree

10 files changed

+5
-46
lines changed

10 files changed

+5
-46
lines changed

themes/vue/layout/index.ejs

+2-3
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,10 @@
163163
})
164164
165165
window.addEventListener('scroll', function () {
166-
var offset = 20
167-
if (window.pageYOffset > offset && !topScrolled) {
166+
if (window.pageYOffset > 165 && !topScrolled) {
168167
topScrolled = true
169168
document.getElementById('mobile-bar').classList.remove('top')
170-
} else if (window.pageYOffset <= offset && topScrolled) {
169+
} else if (window.pageYOffset <= 165 && topScrolled) {
171170
topScrolled = false
172171
document.getElementById('mobile-bar').classList.add('top')
173172
}

themes/vue/layout/layout.ejs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<% var isIndex = page.path === 'index.html' %>
22
<% var isThemes = page.path === 'resources/themes.html' %>
3-
<% var hasVueSchoolBanner = true %>
3+
<% var hasVueSchoolBanner = false %>
44

55
<!DOCTYPE html>
66
<html lang="en" class="with-v3-banner">
@@ -55,7 +55,7 @@
5555
<link href="https://fonts.gstatic.com" rel="preconnect" crossorigin>
5656
<link href="https://maxcdn.bootstrapcdn.com" rel="preconnect" crossorigin>
5757

58-
<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto|Roboto Mono&display=swap" rel="stylesheet">
58+
<link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto Mono&display=swap" rel="stylesheet">
5959
<link href="https://fonts.googleapis.com/css?family=Dosis:500&text=Vue.js&display=swap" rel="stylesheet">
6060

6161
<link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" rel="stylesheet">

themes/vue/source/css/_header.styl

-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ body.docs
143143
display: none
144144
box-shadow: 0 0 2px rgba(0,0,0,.25)
145145
pointer-events: none
146-
transition: background-color 0.25s ease-in
147146
> *
148147
pointer-events: auto
149148
.menu-button

themes/vue/source/css/index.styl

-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
@import "_sponsors-index"
55
@import "_modal"
66
@import "_themes"
7-
@import "_vueschool.styl"
87

98
$width = 900px
109
$space = 40px

themes/vue/source/css/page.styl

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
@import "_scrimba"
1717
@import "_vue-mastery"
1818
@import "_themes"
19-
@import "_vueschool.styl"
2019

2120
#header
2221
box-shadow: 0 0 1px rgba(0,0,0,.25)

themes/vue/source/images/banners/close.svg

-7
This file was deleted.
-6.09 KB
Binary file not shown.

themes/vue/source/images/banners/vs-iso.svg

-13
This file was deleted.

themes/vue/source/images/banners/vs-logo.svg

-16
This file was deleted.

themes/vue/source/js/common.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
initMobileMenu()
44
initVideoModal()
55
initNewNavLinks()
6-
initVueSchoolBanner()
76
if (PAGE_TYPE) {
87
initVersionSelect()
98
initApiSpecLinks()
@@ -441,7 +440,7 @@
441440
if(dataTypeAttr && dataTypeAttr.nodeValue === 'theme-product-title') {
442441
return 300
443442
}
444-
return localStorage.getItem('VS_SUMMER_BANNER_CLOSED') ? 0 : 80
443+
return 0
445444
}
446445
})
447446
}

0 commit comments

Comments
 (0)