Remove Vue School Summer Sale banner

nicodevs · nicodevs · commit 0e41ae3c4750 · 2021-06-25T15:06:34.000-03:00
diff --git a/themes/vue/layout/index.ejs b/themes/vue/layout/index.ejs
@@ -163,11 +163,10 @@
   })
 
   window.addEventListener('scroll', function () {
-    var offset = 20
-    if (window.pageYOffset > offset && !topScrolled) {
+    if (window.pageYOffset > 165 && !topScrolled) {
       topScrolled = true
       document.getElementById('mobile-bar').classList.remove('top')
-    } else if (window.pageYOffset <= offset && topScrolled) {
+    } else if (window.pageYOffset <= 165 && topScrolled) {
       topScrolled = false
       document.getElementById('mobile-bar').classList.add('top')
     }
diff --git a/themes/vue/layout/layout.ejs b/themes/vue/layout/layout.ejs
@@ -1,6 +1,6 @@
 <% var isIndex = page.path === 'index.html' %>
 <% var isThemes = page.path === 'resources/themes.html' %>
-<% var hasVueSchoolBanner = true %>
+<% var hasVueSchoolBanner = false %>
 
 <!DOCTYPE html>
 <html lang="en" class="with-v3-banner">
@@ -55,7 +55,7 @@
     <link href="https://fonts.gstatic.com" rel="preconnect" crossorigin>
     <link href="https://maxcdn.bootstrapcdn.com" rel="preconnect" crossorigin>
 
-    <link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto|Roboto Mono&display=swap" rel="stylesheet">
+    <link href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600|Roboto Mono&display=swap" rel="stylesheet">
     <link href="https://fonts.googleapis.com/css?family=Dosis:500&text=Vue.js&display=swap" rel="stylesheet">
 
     <link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" rel="stylesheet">
diff --git a/themes/vue/source/css/_header.styl b/themes/vue/source/css/_header.styl
@@ -143,7 +143,6 @@ body.docs
   display: none
   box-shadow: 0 0 2px rgba(0,0,0,.25)
   pointer-events: none
-  transition: background-color 0.25s ease-in
   > *
     pointer-events: auto
   .menu-button
diff --git a/themes/vue/source/css/index.styl b/themes/vue/source/css/index.styl
@@ -4,7 +4,6 @@
 @import "_sponsors-index"
 @import "_modal"
 @import "_themes"
-@import "_vueschool.styl"
 
 $width = 900px
 $space = 40px
diff --git a/themes/vue/source/css/page.styl b/themes/vue/source/css/page.styl
@@ -16,7 +16,6 @@
 @import "_scrimba"
 @import "_vue-mastery"
 @import "_themes"
-@import "_vueschool.styl"
 
 #header
   box-shadow: 0 0 1px rgba(0,0,0,.25)
diff --git a/themes/vue/source/js/common.js b/themes/vue/source/js/common.js
@@ -3,7 +3,6 @@
   initMobileMenu()
   initVideoModal()
   initNewNavLinks()
-  initVueSchoolBanner()
   if (PAGE_TYPE) {
     initVersionSelect()
     initApiSpecLinks()
@@ -441,7 +440,7 @@
           if(dataTypeAttr && dataTypeAttr.nodeValue === 'theme-product-title') {
             return 300
           }
-          return localStorage.getItem('VS_SUMMER_BANNER_CLOSED') ? 0 : 80
+          return 0
         }
       })
     }

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`initMobileMenu()`
`4`	`4`	`initVideoModal()`
`5`	`5`	`initNewNavLinks()`
`6`		`- initVueSchoolBanner()`
`7`	`6`	`if (PAGE_TYPE) {`
`8`	`7`	`initVersionSelect()`
`9`	`8`	`initApiSpecLinks()`
`@@ -441,7 +440,7 @@`
`441`	`440`	`if(dataTypeAttr && dataTypeAttr.nodeValue === 'theme-product-title') {`
`442`	`441`	`return 300`
`443`	`442`	`}`
`444`		`- return localStorage.getItem('VS_SUMMER_BANNER_CLOSED') ? 0 : 80`
	`443`	`+ return 0`
`445`	`444`	`}`
`446`	`445`	`})`
`447`	`446`	`}`