From c51cbe24a1f3f80fc802cacb0e81d228abb793cc Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Tue, 13 Nov 2018 02:06:43 +0900
Subject: [PATCH 1/5] =?UTF-8?q?=E2=AD=90=EF=B8=8FNew:=20Add=20`vue/valid-s?=
 =?UTF-8?q?lot-scope`=20rule?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 README.md                           |   1 +
 docs/rules/valid-slot-scope.md      |  74 ++++++
 lib/index.js                        |   1 +
 lib/rules/valid-slot-scope.js       | 137 ++++++++++
 tests/lib/rules/valid-slot-scope.js | 393 ++++++++++++++++++++++++++++
 5 files changed, 606 insertions(+)
 create mode 100644 docs/rules/valid-slot-scope.md
 create mode 100644 lib/rules/valid-slot-scope.js
 create mode 100644 tests/lib/rules/valid-slot-scope.js

diff --git a/README.md b/README.md
index 0ec452586..28eb04521 100644
--- a/README.md
+++ b/README.md
@@ -238,6 +238,7 @@ Enforce all the rules in this category, as well as all higher priority rules, wi
 | :wrench: | [vue/script-indent](./docs/rules/script-indent.md) | enforce consistent indentation in `<script>` |
 | :wrench: | [vue/singleline-html-element-content-newline](./docs/rules/singleline-html-element-content-newline.md) | require a line break before and after the contents of a singleline element |
 |  | [vue/use-v-on-exact](./docs/rules/use-v-on-exact.md) | enforce usage of `exact` modifier on `v-on` |
+|  | [vue/valid-slot-scope](./docs/rules/valid-slot-scope.md) | enforce valid `slot-scope` attributes |
 
 ### Deprecated
 
diff --git a/docs/rules/valid-slot-scope.md b/docs/rules/valid-slot-scope.md
new file mode 100644
index 000000000..d27a0c808
--- /dev/null
+++ b/docs/rules/valid-slot-scope.md
@@ -0,0 +1,74 @@
+# enforce valid `slot-scope` attributes (vue/valid-slot-scope)
+
+This rule checks whether every `slot-scope` (or `scope`) attributes is valid.
+
+## :book: Rule Details
+
+This rule reports `slot-scope` attributes in the following cases:
+
+- The `slot-scope` attribute does not have that attribute value. E.g. `<div slot-scope></div>`
+- The `slot-scope` attribute have the attribute value which is extra access to slot data. E.g. `<div slot-scope="prop, extra"></div>`
+- The `slot-scope` attribute have the attribute value which is rest parameter. E.g. `<div slot-scope="...props"></div>`
+
+This rule does not check syntax errors in directives because it's checked by [no-parsing-error] rule.
+
+:-1: Examples of **incorrect** code for this rule:
+
+```vue
+<template>
+  <TheComponent>
+    <template slot-scope>
+      ...
+    </template>
+  </TheComponent>
+  <TheComponent>
+    <template slot-scope="">
+      ...
+    </template>
+  </TheComponent>
+  <TheComponent>
+    <template slot-scope="a, b, c">
+      <!-- `b` and `c` are extra access. -->
+      ...
+    </template>
+  </TheComponent>
+  <TheComponent>
+    <template slot-scope="...props">
+      ...
+    </template>
+  </TheComponent>
+</template>
+```
+
+:+1: Examples of **correct** code for this rule:
+
+```vue
+<template>
+  <TheComponent>
+    <template slot-scope="prop">
+      ...
+    </template>
+  </TheComponent>
+  <TheComponent>
+    <template slot-scope="{ a, b, c }">
+      ...
+    </template>
+  </TheComponent>
+  <TheComponent>
+    <template slot-scope="[ a, b, c ]">
+      ...
+    </template>
+  </TheComponent>
+</template>
+```
+
+## :wrench: Options
+
+Nothing.
+
+## :couple: Related rules
+
+- [no-parsing-error]
+
+
+[no-parsing-error]: no-parsing-error.md
diff --git a/lib/index.js b/lib/index.js
index 5952af45a..2d5683011 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -55,6 +55,7 @@ module.exports = {
     'use-v-on-exact': require('./rules/use-v-on-exact'),
     'v-bind-style': require('./rules/v-bind-style'),
     'v-on-style': require('./rules/v-on-style'),
+    'valid-slot-scope': require('./rules/valid-slot-scope'),
     'valid-template-root': require('./rules/valid-template-root'),
     'valid-v-bind': require('./rules/valid-v-bind'),
     'valid-v-cloak': require('./rules/valid-v-cloak'),
diff --git a/lib/rules/valid-slot-scope.js b/lib/rules/valid-slot-scope.js
new file mode 100644
index 000000000..65e8eb2fa
--- /dev/null
+++ b/lib/rules/valid-slot-scope.js
@@ -0,0 +1,137 @@
+/**
+ * @fileoverview enforce valid `slot-scope` attributes
+ * @author Yosuke Ota
+ */
+'use strict'
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+const utils = require('../utils')
+
+// ------------------------------------------------------------------------------
+// Helpers
+// ------------------------------------------------------------------------------
+
+/**
+ * Check whether the given token is a comma.
+ * @param {Token} token The token to check.
+ * @returns {boolean} `true` if the token is a comma.
+ */
+function isComma (token) {
+  return token != null && token.type === 'Punctuator' && token.value === ','
+}
+
+/**
+ * Check whether the given token is a quote.
+ * @param {Token} token The token to check.
+ * @returns {boolean} `true` if the token is a quote.
+ */
+function isQuote (token) {
+  return token != null && token.type === 'Punctuator' && (token.value === '"' || token.value === "'")
+}
+
+/**
+ * Gets the extra access parameter tokens of the given slot-scope node.
+ * @param {ASTNode} node The slot-scope node to check.
+ * @param {TokenStore} tokenStore The TokenStore.
+ * @returns {Array} the extra tokens.
+ */
+function getExtraAccessParameterTokens (node, tokenStore) {
+  const valueNode = node.value
+  const result = []
+  const valueFirstToken = tokenStore.getFirstToken(valueNode)
+  const valueLastToken = tokenStore.getLastToken(valueNode)
+  const exprLastToken = isQuote(valueFirstToken) && isQuote(valueLastToken) && valueFirstToken.value === valueLastToken.value
+    ? tokenStore.getTokenBefore(valueLastToken)
+    : valueLastToken
+  const idLastToken = tokenStore.getLastToken(valueNode.expression.id)
+  if (idLastToken !== exprLastToken) {
+    // e.g. `<div slot-scope="a, b">`
+    //                         ^^^ Invalid
+    result.push(...tokenStore.getTokensBetween(idLastToken, exprLastToken))
+    result.push(exprLastToken)
+  }
+
+  return result
+}
+
+// ------------------------------------------------------------------------------
+// Rule Definition
+// ------------------------------------------------------------------------------
+
+module.exports = {
+  meta: {
+    docs: {
+      description: 'enforce valid `slot-scope` attributes',
+      category: undefined,
+      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.4/docs/rules/valid-slot-scope.md'
+    },
+    fixable: null,
+    schema: [],
+    messages: {
+      expectedValue: "'{{attrName}}' attributes require a value.",
+      unexpectedRestParameter: 'The top level rest parameter is useless.',
+      unexpectedExtraAccessParams: 'Unexpected extra access parameters `{{value}}`.',
+      unexpectedTrailingComma: 'Unexpected trailing comma.'
+    }
+  },
+
+  create (context) {
+    const tokenStore =
+      context.parserServices.getTemplateBodyTokenStore &&
+      context.parserServices.getTemplateBodyTokenStore()
+    return utils.defineTemplateBodyVisitor(context, {
+      'VAttribute[directive=true][key.name=/^(slot-)?scope$/]' (node) {
+        if (!utils.hasAttributeValue(node)) {
+          context.report({
+            node,
+            loc: node.loc,
+            messageId: 'expectedValue',
+            data: { attrName: node.key.name }
+          })
+          return
+        }
+
+        const idNode = node.value.expression.id
+        if (idNode.type === 'RestElement') {
+          // e.g. `<div slot-scope="...a">`
+          context.report({
+            node: idNode,
+            loc: idNode.loc,
+            messageId: 'unexpectedRestParameter'
+          })
+        }
+
+        const extraAccessParameterTokens = getExtraAccessParameterTokens(node, tokenStore)
+        if (extraAccessParameterTokens.length) {
+          const startToken = extraAccessParameterTokens[0]
+          if (extraAccessParameterTokens.length === 1 && isComma(startToken)) {
+            context.report({
+              node: startToken,
+              loc: startToken.loc,
+              messageId: 'unexpectedTrailingComma'
+            })
+          } else {
+            const endToken = extraAccessParameterTokens[extraAccessParameterTokens.length - 1]
+            const value = context.getSourceCode().text.slice(
+              extraAccessParameterTokens.length > 1 && isComma(startToken)
+                ? extraAccessParameterTokens[1].range[0]
+                : startToken.range[0],
+              endToken.range[1]
+            )
+            context.report({
+              loc: {
+                start: startToken.loc.start,
+                end: endToken.loc.end
+              },
+              messageId: 'unexpectedExtraAccessParams',
+              data: { value }
+            })
+          }
+        }
+      }
+    })
+  }
+}
diff --git a/tests/lib/rules/valid-slot-scope.js b/tests/lib/rules/valid-slot-scope.js
new file mode 100644
index 000000000..f18b66ce1
--- /dev/null
+++ b/tests/lib/rules/valid-slot-scope.js
@@ -0,0 +1,393 @@
+/**
+ * @author Yosuke Ota
+ */
+'use strict'
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+const RuleTester = require('eslint').RuleTester
+const rule = require('../../../lib/rules/valid-slot-scope')
+
+// ------------------------------------------------------------------------------
+// Tests
+// ------------------------------------------------------------------------------
+
+const tester = new RuleTester({
+  parser: 'vue-eslint-parser',
+  parserOptions: { ecmaVersion: 2018 }
+})
+
+tester.run('valid-slot-scope', rule, {
+  valid: [
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="slotProps">
+              {{slotProps.name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope='slotProps'>
+              {{slotProps.name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope=slotProps>
+              {{slotProps.name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="{name}">
+              {{name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope='{name}'>
+              {{name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope={name}>
+              {{name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="slotProps = { name: 'default' }">
+              {{slotProps.name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="[a, b]">
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="[a, ...b]">
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="{a, ...b}">
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="     slotProps     ">
+              {{slotProps.name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope=" /*comment*/ slotProps /*comment*/ ">
+              {{slotProps.name}}
+            </div>
+          </MyComponent>
+        </template>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <template scope="slotProps">
+              <div>
+                {{slotProps.name}}
+              </div>
+            </template>
+          </MyComponent>
+        </template>
+      `
+    }
+  ],
+  invalid: [
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope />
+          </MyComponent>
+        </template>
+      `,
+      errors: [{
+        message: "'slot-scope' attributes require a value.",
+        line: 4,
+        column: 18,
+        endColumn: 28
+      }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="" />
+          </MyComponent>
+        </template>
+      `,
+      errors: [{
+        message: "'slot-scope' attributes require a value.",
+        line: 4
+      }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <template scope="">
+              <div />
+            </template>
+          </MyComponent>
+        </template>
+      `,
+      errors: [{
+        message: "'scope' attributes require a value.",
+        line: 4
+      }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="...args">
+              {{args}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [{
+        message: 'The top level rest parameter is useless.',
+        line: 4,
+        column: 30,
+        endColumn: 37
+      }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="a, b  ">
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [{
+        message: 'Unexpected extra access parameters `b`.',
+        line: 4,
+        column: 31,
+        endColumn: 34
+      }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="{a} , b">
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [{
+        message: 'Unexpected extra access parameters `b`.',
+        line: 4,
+        column: 34,
+        endColumn: 37
+      }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="a, b, c, d /**/">
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [{
+        message: 'Unexpected extra access parameters `b, c, d`.',
+        line: 4,
+        column: 31,
+        endColumn: 40
+      }]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope='a, b'>
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [
+        'Unexpected extra access parameters `b`.'
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope=a,b>
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [
+        'Unexpected extra access parameters `b`.'
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope=a,{b}>
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [
+        'Unexpected extra access parameters `{b}`.'
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope=a,[b]>
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [
+        'Unexpected extra access parameters `[b]`.'
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope="a,">
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [
+        'Unexpected trailing comma.'
+      ]
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <MyComponent>
+            <div slot-scope=a,>
+              {{a}}
+            </div>
+          </MyComponent>
+        </template>
+      `,
+      errors: [
+        'Unexpected trailing comma.'
+      ]
+    }
+  ]
+})

From f149d81172e3a36b2e6800314774b4e12e3c3b6b Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Sun, 18 Nov 2018 19:52:33 +0900
Subject: [PATCH 2/5] Add `Related links` to doc

---
 docs/rules/valid-slot-scope.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/docs/rules/valid-slot-scope.md b/docs/rules/valid-slot-scope.md
index d27a0c808..ee052b135 100644
--- a/docs/rules/valid-slot-scope.md
+++ b/docs/rules/valid-slot-scope.md
@@ -70,5 +70,8 @@ Nothing.
 
 - [no-parsing-error]
 
+## Related links
+
+- [Guide - Scoped Slots](https://vuejs.org/v2/guide/components-slots.html#Scoped-Slots)
 
 [no-parsing-error]: no-parsing-error.md

From bf99834c35aa4b82d48ffb4d1e094a204f5c6e76 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Sat, 24 Nov 2018 01:30:06 +0900
Subject: [PATCH 3/5] Fixed lint error

---
 lib/rules/valid-slot-scope.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rules/valid-slot-scope.js b/lib/rules/valid-slot-scope.js
index 65e8eb2fa..48acc9658 100644
--- a/lib/rules/valid-slot-scope.js
+++ b/lib/rules/valid-slot-scope.js
@@ -66,7 +66,7 @@ module.exports = {
     docs: {
       description: 'enforce valid `slot-scope` attributes',
       category: undefined,
-      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.4/docs/rules/valid-slot-scope.md'
+      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.5/docs/rules/valid-slot-scope.md'
     },
     fixable: null,
     schema: [],

From 609ad9005f01762599a96d981bb746dc2bac1163 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Sat, 24 Nov 2018 17:13:32 +0900
Subject: [PATCH 4/5] Upgraded `vue-eslint-parser`. And remove the case of a
 syntax error from the target to be verified.

---
 docs/rules/valid-slot-scope.md      |  13 ---
 lib/rules/valid-slot-scope.js       |  94 +++++-------------
 package.json                        |   2 +-
 tests/lib/rules/valid-slot-scope.js | 143 ++++++++++------------------
 4 files changed, 76 insertions(+), 176 deletions(-)

diff --git a/docs/rules/valid-slot-scope.md b/docs/rules/valid-slot-scope.md
index ee052b135..6cb00b910 100644
--- a/docs/rules/valid-slot-scope.md
+++ b/docs/rules/valid-slot-scope.md
@@ -7,8 +7,6 @@ This rule checks whether every `slot-scope` (or `scope`) attributes is valid.
 This rule reports `slot-scope` attributes in the following cases:
 
 - The `slot-scope` attribute does not have that attribute value. E.g. `<div slot-scope></div>`
-- The `slot-scope` attribute have the attribute value which is extra access to slot data. E.g. `<div slot-scope="prop, extra"></div>`
-- The `slot-scope` attribute have the attribute value which is rest parameter. E.g. `<div slot-scope="...props"></div>`
 
 This rule does not check syntax errors in directives because it's checked by [no-parsing-error] rule.
 
@@ -26,17 +24,6 @@ This rule does not check syntax errors in directives because it's checked by [no
       ...
     </template>
   </TheComponent>
-  <TheComponent>
-    <template slot-scope="a, b, c">
-      <!-- `b` and `c` are extra access. -->
-      ...
-    </template>
-  </TheComponent>
-  <TheComponent>
-    <template slot-scope="...props">
-      ...
-    </template>
-  </TheComponent>
 </template>
 ```
 
diff --git a/lib/rules/valid-slot-scope.js b/lib/rules/valid-slot-scope.js
index 48acc9658..2e7549576 100644
--- a/lib/rules/valid-slot-scope.js
+++ b/lib/rules/valid-slot-scope.js
@@ -14,15 +14,6 @@ const utils = require('../utils')
 // Helpers
 // ------------------------------------------------------------------------------
 
-/**
- * Check whether the given token is a comma.
- * @param {Token} token The token to check.
- * @returns {boolean} `true` if the token is a comma.
- */
-function isComma (token) {
-  return token != null && token.type === 'Punctuator' && token.value === ','
-}
-
 /**
  * Check whether the given token is a quote.
  * @param {Token} token The token to check.
@@ -33,28 +24,29 @@ function isQuote (token) {
 }
 
 /**
- * Gets the extra access parameter tokens of the given slot-scope node.
+ * Check whether the value of the given slot-scope node is a syntax error.
  * @param {ASTNode} node The slot-scope node to check.
  * @param {TokenStore} tokenStore The TokenStore.
- * @returns {Array} the extra tokens.
+ * @returns {boolean} `true` if the value is a syntax error
  */
-function getExtraAccessParameterTokens (node, tokenStore) {
-  const valueNode = node.value
-  const result = []
-  const valueFirstToken = tokenStore.getFirstToken(valueNode)
-  const valueLastToken = tokenStore.getLastToken(valueNode)
-  const exprLastToken = isQuote(valueFirstToken) && isQuote(valueLastToken) && valueFirstToken.value === valueLastToken.value
-    ? tokenStore.getTokenBefore(valueLastToken)
-    : valueLastToken
-  const idLastToken = tokenStore.getLastToken(valueNode.expression.id)
-  if (idLastToken !== exprLastToken) {
-    // e.g. `<div slot-scope="a, b">`
-    //                         ^^^ Invalid
-    result.push(...tokenStore.getTokensBetween(idLastToken, exprLastToken))
-    result.push(exprLastToken)
+function isSyntaxError (node, tokenStore) {
+  if (node.value == null) {
+    // does not have value.
+    return false
   }
-
-  return result
+  if (node.value.expression != null) {
+    return false
+  }
+  const tokens = tokenStore.getTokens(node.value)
+  if (!tokens.length) {
+    // empty value
+    return false
+  }
+  if (tokens.length === 2 && tokens.every(isQuote)) {
+    // empty value e.g `""` / `''`
+    return false
+  }
+  return true
 }
 
 // ------------------------------------------------------------------------------
@@ -71,10 +63,7 @@ module.exports = {
     fixable: null,
     schema: [],
     messages: {
-      expectedValue: "'{{attrName}}' attributes require a value.",
-      unexpectedRestParameter: 'The top level rest parameter is useless.',
-      unexpectedExtraAccessParams: 'Unexpected extra access parameters `{{value}}`.',
-      unexpectedTrailingComma: 'Unexpected trailing comma.'
+      expectedValue: "'{{attrName}}' attributes require a value."
     }
   },
 
@@ -85,51 +74,16 @@ module.exports = {
     return utils.defineTemplateBodyVisitor(context, {
       'VAttribute[directive=true][key.name=/^(slot-)?scope$/]' (node) {
         if (!utils.hasAttributeValue(node)) {
+          if (isSyntaxError(node, tokenStore)) {
+            // syntax error
+            return
+          }
           context.report({
             node,
             loc: node.loc,
             messageId: 'expectedValue',
             data: { attrName: node.key.name }
           })
-          return
-        }
-
-        const idNode = node.value.expression.id
-        if (idNode.type === 'RestElement') {
-          // e.g. `<div slot-scope="...a">`
-          context.report({
-            node: idNode,
-            loc: idNode.loc,
-            messageId: 'unexpectedRestParameter'
-          })
-        }
-
-        const extraAccessParameterTokens = getExtraAccessParameterTokens(node, tokenStore)
-        if (extraAccessParameterTokens.length) {
-          const startToken = extraAccessParameterTokens[0]
-          if (extraAccessParameterTokens.length === 1 && isComma(startToken)) {
-            context.report({
-              node: startToken,
-              loc: startToken.loc,
-              messageId: 'unexpectedTrailingComma'
-            })
-          } else {
-            const endToken = extraAccessParameterTokens[extraAccessParameterTokens.length - 1]
-            const value = context.getSourceCode().text.slice(
-              extraAccessParameterTokens.length > 1 && isComma(startToken)
-                ? extraAccessParameterTokens[1].range[0]
-                : startToken.range[0],
-              endToken.range[1]
-            )
-            context.report({
-              loc: {
-                start: startToken.loc.start,
-                end: endToken.loc.end
-              },
-              messageId: 'unexpectedExtraAccessParams',
-              data: { value }
-            })
-          }
         }
       }
     })
diff --git a/package.json b/package.json
index 5f93170b7..fb56fbe59 100644
--- a/package.json
+++ b/package.json
@@ -44,7 +44,7 @@
     "eslint": "^5.0.0"
   },
   "dependencies": {
-    "vue-eslint-parser": "^3.2.1"
+    "vue-eslint-parser": "^3.3.0"
   },
   "devDependencies": {
     "@types/node": "^4.2.16",
diff --git a/tests/lib/rules/valid-slot-scope.js b/tests/lib/rules/valid-slot-scope.js
index f18b66ce1..109f542ca 100644
--- a/tests/lib/rules/valid-slot-scope.js
+++ b/tests/lib/rules/valid-slot-scope.js
@@ -178,216 +178,175 @@ tester.run('valid-slot-scope', rule, {
           </MyComponent>
         </template>
       `
-    }
-  ],
-  invalid: [
+    },
+    // parse errors
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope />
+            <div slot-scope="...args">
+              {{args}}
+            </div>
           </MyComponent>
         </template>
-      `,
-      errors: [{
-        message: "'slot-scope' attributes require a value.",
-        line: 4,
-        column: 18,
-        endColumn: 28
-      }]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope="" />
+            <div slot-scope="a, b  ">
+              {{a}}
+            </div>
           </MyComponent>
         </template>
-      `,
-      errors: [{
-        message: "'slot-scope' attributes require a value.",
-        line: 4
-      }]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <template scope="">
-              <div />
-            </template>
+            <div slot-scope="{a} , b">
+              {{a}}
+            </div>
           </MyComponent>
         </template>
-      `,
-      errors: [{
-        message: "'scope' attributes require a value.",
-        line: 4
-      }]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope="...args">
-              {{args}}
+            <div slot-scope="a, b, c, d /**/">
+              {{a}}
             </div>
           </MyComponent>
         </template>
-      `,
-      errors: [{
-        message: 'The top level rest parameter is useless.',
-        line: 4,
-        column: 30,
-        endColumn: 37
-      }]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope="a, b  ">
+            <div slot-scope='a, b'>
               {{a}}
             </div>
           </MyComponent>
         </template>
-      `,
-      errors: [{
-        message: 'Unexpected extra access parameters `b`.',
-        line: 4,
-        column: 31,
-        endColumn: 34
-      }]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope="{a} , b">
+            <div slot-scope=a,b>
               {{a}}
             </div>
           </MyComponent>
         </template>
-      `,
-      errors: [{
-        message: 'Unexpected extra access parameters `b`.',
-        line: 4,
-        column: 34,
-        endColumn: 37
-      }]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope="a, b, c, d /**/">
+            <div slot-scope=a,{b}>
               {{a}}
             </div>
           </MyComponent>
         </template>
-      `,
-      errors: [{
-        message: 'Unexpected extra access parameters `b, c, d`.',
-        line: 4,
-        column: 31,
-        endColumn: 40
-      }]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope='a, b'>
+            <div slot-scope=a,[b]>
               {{a}}
             </div>
           </MyComponent>
         </template>
-      `,
-      errors: [
-        'Unexpected extra access parameters `b`.'
-      ]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope=a,b>
+            <div slot-scope="a,">
               {{a}}
             </div>
           </MyComponent>
         </template>
-      `,
-      errors: [
-        'Unexpected extra access parameters `b`.'
-      ]
+      `
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope=a,{b}>
+            <div slot-scope=a,>
               {{a}}
             </div>
           </MyComponent>
         </template>
-      `,
-      errors: [
-        'Unexpected extra access parameters `{b}`.'
-      ]
-    },
+      `
+    }
+  ],
+  invalid: [
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope=a,[b]>
-              {{a}}
-            </div>
+            <div slot-scope />
           </MyComponent>
         </template>
       `,
-      errors: [
-        'Unexpected extra access parameters `[b]`.'
-      ]
+      errors: [{
+        message: "'slot-scope' attributes require a value.",
+        line: 4,
+        column: 18,
+        endColumn: 28
+      }]
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope="a,">
-              {{a}}
-            </div>
+            <div slot-scope="" />
           </MyComponent>
         </template>
       `,
-      errors: [
-        'Unexpected trailing comma.'
-      ]
+      errors: [{
+        message: "'slot-scope' attributes require a value.",
+        line: 4
+      }]
     },
     {
       filename: 'test.vue',
       code: `
         <template>
           <MyComponent>
-            <div slot-scope=a,>
-              {{a}}
-            </div>
+            <template scope="">
+              <div />
+            </template>
           </MyComponent>
         </template>
       `,
-      errors: [
-        'Unexpected trailing comma.'
-      ]
+      errors: [{
+        message: "'scope' attributes require a value.",
+        line: 4
+      }]
     }
   ]
 })

From 85ee7d97a1d67c9432fb3d6f02d94095a95c04da Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Tue, 4 Dec 2018 13:45:31 +0900
Subject: [PATCH 5/5] update document

---
 docs/rules/README.md           |  1 +
 docs/rules/valid-slot-scope.md | 46 +++++++++++++++++++++-------------
 lib/rules/valid-slot-scope.js  |  2 +-
 3 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/docs/rules/README.md b/docs/rules/README.md
index dcc4d9b2a..440339503 100644
--- a/docs/rules/README.md
+++ b/docs/rules/README.md
@@ -136,6 +136,7 @@ For example:
 | Rule ID | Description |    |
 |:--------|:------------|:---|
 | [vue/script-indent](./script-indent.md) | enforce consistent indentation in `<script>` | :wrench: |
+| [vue/valid-slot-scope](./valid-slot-scope.md) | enforce valid `slot-scope` attributes |  |
 
 ## Deprecated
 
diff --git a/docs/rules/valid-slot-scope.md b/docs/rules/valid-slot-scope.md
index 6cb00b910..c3a35aa26 100644
--- a/docs/rules/valid-slot-scope.md
+++ b/docs/rules/valid-slot-scope.md
@@ -1,4 +1,11 @@
-# enforce valid `slot-scope` attributes (vue/valid-slot-scope)
+---
+pageClass: rule-details
+sidebarDepth: 0
+title: vue/valid-slot-scope
+description: enforce valid `slot-scope` attributes
+---
+# vue/valid-slot-scope
+> enforce valid `slot-scope` attributes
 
 This rule checks whether every `slot-scope` (or `scope`) attributes is valid.
 
@@ -8,46 +15,44 @@ This rule reports `slot-scope` attributes in the following cases:
 
 - The `slot-scope` attribute does not have that attribute value. E.g. `<div slot-scope></div>`
 
-This rule does not check syntax errors in directives because it's checked by [no-parsing-error] rule.
-
-:-1: Examples of **incorrect** code for this rule:
-
+<eslint-code-block :rules="{'vue/valid-slot-scope': ['error']}">
 ```vue
 <template>
+  <!-- ✓ GOOD -->
   <TheComponent>
-    <template slot-scope>
+    <template slot-scope="prop">
       ...
     </template>
   </TheComponent>
   <TheComponent>
-    <template slot-scope="">
+    <template slot-scope="{ a, b, c }">
       ...
     </template>
   </TheComponent>
-</template>
-```
-
-:+1: Examples of **correct** code for this rule:
-
-```vue
-<template>
   <TheComponent>
-    <template slot-scope="prop">
+    <template slot-scope="[ a, b, c ]">
       ...
     </template>
   </TheComponent>
+
+  <!-- ✗ BAD -->
   <TheComponent>
-    <template slot-scope="{ a, b, c }">
+    <template slot-scope>
       ...
     </template>
   </TheComponent>
   <TheComponent>
-    <template slot-scope="[ a, b, c ]">
+    <template slot-scope="">
       ...
     </template>
   </TheComponent>
 </template>
 ```
+</eslint-code-block>
+
+::: warning Note
+This rule does not check syntax errors in directives because it's checked by [no-parsing-error] rule.
+:::
 
 ## :wrench: Options
 
@@ -57,8 +62,13 @@ Nothing.
 
 - [no-parsing-error]
 
-## Related links
+## :books: Further reading
 
 - [Guide - Scoped Slots](https://vuejs.org/v2/guide/components-slots.html#Scoped-Slots)
 
 [no-parsing-error]: no-parsing-error.md
+
+## :mag: Implementation
+
+- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/valid-slot-scope.js)
+- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/valid-slot-scope.js)
diff --git a/lib/rules/valid-slot-scope.js b/lib/rules/valid-slot-scope.js
index 2e7549576..776635c8d 100644
--- a/lib/rules/valid-slot-scope.js
+++ b/lib/rules/valid-slot-scope.js
@@ -58,7 +58,7 @@ module.exports = {
     docs: {
       description: 'enforce valid `slot-scope` attributes',
       category: undefined,
-      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.5/docs/rules/valid-slot-scope.md'
+      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0/docs/rules/valid-slot-scope.md'
     },
     fixable: null,
     schema: [],