Skip to content

Improve detection of components in no-unused-components rule #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2018
Merged

Improve detection of components in no-unused-components rule #606

merged 1 commit into from
Oct 20, 2018

Conversation

jastkand
Copy link
Contributor

The no-unused-components raises an error when the component is imported in camelCase. This PR fixes this behavior.

<template>
  <div>
    <the-button />
  </div>
</template>

<script>
  import theButton from './theButton.vue'
  export default {
    components: {
      theButton
    }
  }
</script>

mysticatea
mysticatea approved these changes Oct 20, 2018
View reviewed changes
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mysticatea mysticatea merged commit 45be306 into vuejs:master Oct 20, 2018
andrew-humu added a commit to andrew-humu/eslint-plugin-vue that referenced this pull request Feb 22, 2019
@andrew-humu
Rule documentation should match change in vuejs#606
9b2a299
@andrew-humu andrew-humu mentioned this pull request Feb 22, 2019
Merged
mysticatea pushed a commit that referenced this pull request Feb 27, 2019
@andrew-humu @mysticatea
Docs: rule documentation should match change in #606 (#828)
db700ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armano2 armano2 armano2 approved these changes

@mysticatea mysticatea mysticatea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jastkand @armano2 @mysticatea