From 89df32be85c17bf59b41624178967223a3108c18 Mon Sep 17 00:00:00 2001 From: waynzh Date: Tue, 5 Mar 2024 13:04:27 +0800 Subject: [PATCH 1/2] fix(v-for-delimiter-style): ignore Punctuator token --- lib/rules/v-for-delimiter-style.js | 2 +- tests/lib/rules/v-for-delimiter-style.js | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rules/v-for-delimiter-style.js b/lib/rules/v-for-delimiter-style.js index 3a4944803..f59a43826 100644 --- a/lib/rules/v-for-delimiter-style.js +++ b/lib/rules/v-for-delimiter-style.js @@ -42,7 +42,7 @@ module.exports = { node.left.length > 0 ? node.left[node.left.length - 1] : tokenStore.getFirstToken(node), - (token) => token.type !== 'Punctuator' || token.value !== ')' + (token) => token.type !== 'Punctuator' ) ) diff --git a/tests/lib/rules/v-for-delimiter-style.js b/tests/lib/rules/v-for-delimiter-style.js index 350fded17..ab13a62fd 100644 --- a/tests/lib/rules/v-for-delimiter-style.js +++ b/tests/lib/rules/v-for-delimiter-style.js @@ -35,6 +35,10 @@ tester.run('v-for-delimiter-style', rule, { filename: 'test.vue', code: '' }, + { + filename: 'test.vue', + code: '' + }, { filename: 'test.vue', code: '', From f36b5303ce970c97c0879cec242525a5189932aa Mon Sep 17 00:00:00 2001 From: waynzh Date: Tue, 5 Mar 2024 15:47:13 +0800 Subject: [PATCH 2/2] test: add test cases --- tests/lib/rules/v-for-delimiter-style.js | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/tests/lib/rules/v-for-delimiter-style.js b/tests/lib/rules/v-for-delimiter-style.js index ab13a62fd..ebec2df56 100644 --- a/tests/lib/rules/v-for-delimiter-style.js +++ b/tests/lib/rules/v-for-delimiter-style.js @@ -36,9 +36,18 @@ tester.run('v-for-delimiter-style', rule, { code: '' }, { + // https://github.com/vuejs/vue-eslint-parser/issues/226 filename: 'test.vue', code: '' }, + { + filename: 'test.vue', + code: '' + }, + { + filename: 'test.vue', + code: '' + }, { filename: 'test.vue', code: '', @@ -62,6 +71,17 @@ tester.run('v-for-delimiter-style', rule, { } ] }, + { + filename: 'test.vue', + code: '', + output: '', + errors: [ + { + message: "Expected 'in' instead of 'of' in 'v-for'.", + column: 23 + } + ] + }, { filename: 'test.vue', code: '',