Skip to content

prop-name-casing autofix removes $ in prop name #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
privatenumber opened this issue Mar 26, 2019 · 2 comments · Fixed by #1152
Closed

prop-name-casing autofix removes $ in prop name #862

privatenumber opened this issue Mar 26, 2019 · 2 comments · Fixed by #1152
Labels

Comments

@privatenumber
Copy link
Contributor

Tell us about your environment

  • ESLint version: 5.15.3
  • eslint-plugin-vue version: 5.2.2
  • Node version: 8.12.0

What did you do?
eslint --fix

What did you expect to happen?
For renaming to happen on non-camelCase props.

What actually happened?
My prop name $actionEl (which I know has another problem of it's own) was renamed to actionEl.

@mysticatea mysticatea added the bug label Mar 27, 2019
@mysticatea
Copy link
Member

Thank you for the report.

I could reproduce it on our online demo.

@privatenumber
Copy link
Contributor Author

In addition to fixing the autofix logic here, it might be worth introducing a rule to prevent non-alphanumerical characters in prop names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants