-
-
Notifications
You must be signed in to change notification settings - Fork 679
Add a link to error output #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also, I suggest adding links to either official doc or style guide in each rule's markdown file. For example, for this one: https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/valid-v-bind.md I think both https://vuejs.org/v2/guide/list.html#key and https://vuejs.org/v2/style-guide/#Keyed-v-for-essential should be linked in a section like |
/cc @chrisvfritz as you might be interested.` |
Good idea @octref with putting links in documentation :) But when it comes to displaying rules' URLs in vuetur's tooltips, you can already take advantage of const getRuleURI = require('eslint-rule-documentation');
getRuleURI('vue/require-v-for-key'); |
Cool idea! Any chance of the links being openable, like via a shortcut? |
Very nice. Thanks for the tip.
This is using |
Cool :) So if the rest is on your side now, let me set the definition of done for us, regarding your suggestion:
|
@octref I added links to more details in all relevant rules :) |
Will upgrade the deps and get it soon. vuejs/vetur#849 |
Unfortunately this still depends on upstream changes in: microsoft/vscode#54272 Otherwise, I cannot render the link in diagnostic hover (the one you saw was on normal hover). |
See vuejs/vetur#738 and vuejs/vetur#261
Many new Vue users are having a hard time figuring out the meaning of the error message for
v-bind:key
.I think it would be nice if eslint-plugin-vue offers a url for each rule, this way I can render the URL and people can find more information about each error there.
The text was updated successfully, but these errors were encountered: