Skip to content

vue/no-mutating-props does not report delete operations #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
CyanSalt opened this issue May 23, 2022 · 0 comments · Fixed by #1942
Closed
2 tasks done

vue/no-mutating-props does not report delete operations #1904

CyanSalt opened this issue May 23, 2022 · 0 comments · Fixed by #1942
Labels
bug

Comments

@CyanSalt
Copy link

Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have read the FAQ and my problem is not listed.

Tell us about your environment

  • ESLint version: 8.16.0
  • eslint-plugin-vue version: 9.0.1

What did you do?

See the demo here.

image

What did you expect to happen?

vue/no-mutating-props should report the delete operation on properties of prop objects, but currently it doesn't.

I noticed that the implementation of findMutating does not check for UnaryExpression. Since deleting properties is also reactive in 3.x, this kind of code will probably come up more often.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: report delete operation for mutation props qmhc/eslint-plugin-vue
2 participants
@FloEdelmann @CyanSalt