Fix issue with spead operator in no-duplicate-field-names

armano2 · armano2 · commit e9b32ad9fc13 · 2017-07-18T02:05:50.000+02:00
diff --git a/lib/rules/no-duplicate-field-names.js b/lib/rules/no-duplicate-field-names.js
@@ -64,7 +64,7 @@ function create (context) {
 
   function checkObjectExpression (node) {
     node.properties.forEach(item => {
-      if (item.key.type === 'Identifier') {
+      if (item.type === 'Property' && item.key.type === 'Identifier') {
         checkUsedNames(item.key.name, item.key)
       }
     })
diff --git a/tests/lib/rules/no-duplicate-field-names.js b/tests/lib/rules/no-duplicate-field-names.js
@@ -49,6 +49,9 @@ ruleTester.run('no-duplicate-field-names', rule, {
             foo: String
           },
           computed: {
+            ...mapGetters({
+              test: 'getTest'
+            }),
             bar: {
               get () {
               }
@@ -65,7 +68,7 @@ ruleTester.run('no-duplicate-field-names', rule, {
           }
         }
       `,
-      parserOptions: { ecmaVersion: 6, sourceType: 'module' }
+      parserOptions: { ecmaVersion: 8, sourceType: 'module', ecmaFeatures: { experimentalObjectRestSpread: true }}
     }
   ],
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ function create (context) {`
`64`	`64`
`65`	`65`	`function checkObjectExpression (node) {`
`66`	`66`	`node.properties.forEach(item => {`
`67`		`- if (item.key.type === 'Identifier') {`
	`67`	`+ if (item.type === 'Property' && item.key.type === 'Identifier') {`
`68`	`68`	`checkUsedNames(item.key.name, item.key)`
`69`	`69`	`}`
`70`	`70`	`})`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,9 @@ ruleTester.run('no-duplicate-field-names', rule, {`
`49`	`49`	`foo: String`
`50`	`50`	`},`
`51`	`51`	`computed: {`
	`52`	`+ ...mapGetters({`
	`53`	`+ test: 'getTest'`
	`54`	`+ }),`
`52`	`55`	`bar: {`
`53`	`56`	`get () {`
`54`	`57`	`}`
`@@ -65,7 +68,7 @@ ruleTester.run('no-duplicate-field-names', rule, {`
`65`	`68`	`}`
`66`	`69`	`}`
`67`	`70`	`,
`68`		`- parserOptions: { ecmaVersion: 6, sourceType: 'module' }`
	`71`	`+ parserOptions: { ecmaVersion: 8, sourceType: 'module', ecmaFeatures: { experimentalObjectRestSpread: true }}`
`69`	`72`	`}`
`70`	`73`	`],`
`71`	`74`