Skip to content

Commit d822a03

Browse files
fiskerkazupon
authored andcommitted
pref: improve traverse (#912)
* pref: improve traverse * ci: trigger build * Remove throw trick
1 parent cb2e367 commit d822a03

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

lib/rules/order-in-components.js

+5-9
Original file line numberDiff line numberDiff line change
@@ -97,27 +97,22 @@ function isNotSideEffectsNode (node, visitorKeys) {
9797
traverseNodes(node, {
9898
visitorKeys,
9999
enterNode (node, parent) {
100-
if (!result || noSideEffectsNodes.has(node)) {
100+
if (!result) {
101101
return
102102
}
103103

104104
if (
105+
// parent has no side effects
106+
noSideEffectsNodes.has(parent) ||
107+
// no side effects node
105108
node.type === 'FunctionExpression' ||
106109
node.type === 'Identifier' ||
107110
node.type === 'Literal' ||
108111
// es2015
109112
node.type === 'ArrowFunctionExpression' ||
110113
node.type === 'TemplateElement'
111114
) {
112-
// no side effects node
113115
noSideEffectsNodes.add(node)
114-
traverseNodes(node, {
115-
visitorKeys,
116-
enterNode (node) {
117-
noSideEffectsNodes.add(node)
118-
},
119-
leaveNode () {}
120-
})
121116
} else if (
122117
node.type !== 'Property' &&
123118
node.type !== 'ObjectExpression' &&
@@ -137,6 +132,7 @@ function isNotSideEffectsNode (node, visitorKeys) {
137132
},
138133
leaveNode () {}
139134
})
135+
140136
return result
141137
}
142138

0 commit comments

Comments
 (0)