Add getStaticPropertyName & apply sugestions from code review

Author: armano2

lib/rules/require-prop-types.js

@@ -12,26 +12,25 @@ function create (context) {
   // ----------------------------------------------------------------------
 
   function objectHasType (nodes) {
-    return !!(nodes
+    const typeProperty = nodes.properties
       .filter(p =>
-        p.key.type === 'Identifier' &&
-        p.key.name === 'type' &&
+        utils.getStaticPropertyName(p.key) === 'type' &&
         (
           p.value.type !== 'ArrayExpression' ||
           p.value.elements.length > 0
         )
-      )[0])
+      )[0]
+    return Boolean(typeProperty)
   }
 
   function checkProperties (items) {
     items.map(cp => {
       if (cp.type !== 'Property') {
         return
       }
-      const key = cp.key.name
       let hasType = true
       if (cp.value.type === 'ObjectExpression') { // foo: {
-        hasType = objectHasType(cp.value.properties)
+        hasType = objectHasType(cp.value)
       } else if (cp.value.type === 'ArrayExpression') { // foo: [
         hasType = cp.value.elements.length > 0
       } else if (cp.value.type === 'FunctionExpression' || cp.value.type === 'ArrowFunctionExpression') {
@@ -42,7 +41,7 @@ function create (context) {
           node: cp,
           message: 'Prop "{{name}}" should define at least it\'s type.',
           data: {
-            name: key
+            name: cp.key.name
           }
         })
       }

lib/utils/index.js

@@ -272,6 +272,48 @@ module.exports = {
     return members.reverse()
   },
 
+  /**
+   * Gets the property name of a given node.
+   * @param {ASTNode} node - The node to get.
+   * @return {string|null} The property name if static. Otherwise, null.
+   */
+  getStaticPropertyName (node) {
+    let prop
+    switch (node && node.type) {
+      case 'Property':
+      case 'MethodDefinition':
+        prop = node.key
+        break
+      case 'MemberExpression':
+        prop = node.property
+        break
+      case 'Literal':
+      case 'TemplateLiteral':
+      case 'Identifier':
+        prop = node
+        break
+      // no default
+    }
+
+    switch (prop && prop.type) {
+      case 'Literal':
+        return String(prop.value)
+      case 'TemplateLiteral':
+        if (prop.expressions.length === 0 && prop.quasis.length === 1) {
+          return prop.quasis[0].value.cooked
+        }
+        break
+      case 'Identifier':
+        if (!node.computed) {
+          return prop.name
+        }
+        break
+      // no default
+    }
+
+    return null
+  },
+
   /**
    * Get all computed properties by looking at all component's properties
    * @param {ObjectExpression} Object with component definition

tests/lib/rules/require-prop-types.js

@@ -55,6 +55,19 @@ ruleTester.run('require-prop-types', rule, {
         }
       `,
       parserOptions: { ecmaVersion: 6, sourceType: 'module' }
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        export default {
+          props: {
+            foo: {
+              ['type']: String
+            }
+          }
+        }
+      `,
+      parserOptions: { ecmaVersion: 6, sourceType: 'module' }
     }
   ],