Skip to content

Commit bd88c1f

Browse files
fix some unit tests
1 parent 681608f commit bd88c1f

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

lib/rules/force-types-on-object-props.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ module.exports = {
8686
)
8787
for (const prop of properties) {
8888
if (!prop) {
89-
break
89+
continue
9090
}
9191
if (isLooksLike(prop.value, { type: 'Identifier', name: 'Object' })) {
9292
context.report({

tests/lib/rules/force-types-on-object-props.js

+12-11
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,21 @@ const RuleTester = require('eslint').RuleTester
88
const rule = require('../../../lib/rules/force-types-on-object-props')
99

1010
const template = (prop) => `
11-
<template></template>
12-
<script>
11+
<script lang="ts">
12+
import { Prop } from 'vue/types/options';
1313
export default {
14+
props: {
15+
prop: {
16+
${prop}
17+
}
18+
}
1419
}
1520
</script>
1621
`
1722

1823
const ruleTester = new RuleTester({
1924
parser: require.resolve('vue-eslint-parser'),
20-
parserOptions: { ecmaVersion: 2015, sourceType: 'module' }
25+
parserOptions: { ecmaVersion: 2015, sourceType: 'module', parser: '@typescript-eslint/parser' }
2126
})
2227

2328
ruleTester.run('force-types-on-object-props', rule, {
@@ -54,35 +59,31 @@ ruleTester.run('force-types-on-object-props', rule, {
5459
code: template('type: Object as any'),
5560
errors: [
5661
{
57-
message:
58-
'Object props should be typed like this: "type: Object as Prop<T>"'
62+
message: 'Object props has to contains type.'
5963
}
6064
]
6165
},
6266
{
6367
code: template('type: Object as {}'),
6468
errors: [
6569
{
66-
message:
67-
'Object props should be typed like this: "type: Object as Prop<T>"'
70+
message: 'Object props has to contains type.'
6871
}
6972
]
7073
},
7174
{
7275
code: template('type: Object as unknown'),
7376
errors: [
7477
{
75-
message:
76-
'Object props should be typed like this: "type: Object as Prop<T>"'
78+
message: 'Object props has to contains type.'
7779
}
7880
]
7981
},
8082
{
8183
code: template('type: Object as string'),
8284
errors: [
8385
{
84-
message:
85-
'Object props should be typed like this: "type: Object as Prop<T>"'
86+
message: 'Object props has to contains type.'
8687
}
8788
]
8889
}

0 commit comments

Comments
 (0)