Skip to content

Commit 6a4a7da

Browse files
authored
Set source type to commonjs to enable rule lint rules again (#2240)
1 parent f669bad commit 6a4a7da

38 files changed

+40
-37
lines changed

Diff for: eslint.config.js

+4
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,16 @@ module.exports = [
4949
files: ['**/*.js'],
5050
languageOptions: {
5151
ecmaVersion: 'latest',
52+
sourceType: 'commonjs',
5253
globals: {
5354
...globals.es6,
5455
...globals.node,
5556
...globals.mocha
5657
}
5758
},
59+
linterOptions: {
60+
reportUnusedDisableDirectives: true
61+
},
5862
rules: {
5963
'accessor-pairs': 2,
6064
camelcase: [2, { properties: 'never' }],

Diff for: lib/rules/array-bracket-newline.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('array-bracket-newline', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/array-bracket-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('array-bracket-spacing', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/array-element-newline.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('array-element-newline', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/arrow-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('arrow-spacing')

Diff for: lib/rules/block-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('block-spacing', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/brace-style.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('brace-style', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/camelcase.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('camelcase')

Diff for: lib/rules/comma-dangle.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('comma-dangle')

Diff for: lib/rules/comma-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('comma-spacing', {
1010
skipDynamicArguments: true,
1111
skipDynamicArgumentsReport: true,

Diff for: lib/rules/comma-style.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('comma-style', {
1010
create(_context, { coreHandlers }) {
1111
return {

Diff for: lib/rules/dot-location.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('dot-location')

Diff for: lib/rules/dot-notation.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('dot-notation', {
1010
applyDocument: true
1111
})

Diff for: lib/rules/eqeqeq.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('eqeqeq', {
1010
applyDocument: true
1111
})

Diff for: lib/rules/func-call-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('func-call-spacing', {
1010
skipDynamicArguments: true,
1111
applyDocument: true

Diff for: lib/rules/key-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('key-spacing', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/keyword-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('keyword-spacing', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/multiline-ternary.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
const { wrapCoreRule } = require('../utils')
88

9-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
9+
// eslint-disable-next-line internal/no-invalid-meta
1010
module.exports = wrapCoreRule('multiline-ternary', {
1111
skipDynamicArguments: true,
1212
applyDocument: true

Diff for: lib/rules/no-console.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
const utils = require('../utils')
88

9-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
9+
// eslint-disable-next-line internal/no-invalid-meta
1010
module.exports = utils.wrapCoreRule('no-console', {
1111
skipCoreHandlers: true,
1212
create(context) {

Diff for: lib/rules/no-constant-condition.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const { wrapCoreRule } = require('../utils')
77

88
const conditionalDirectiveNames = new Set(['v-show', 'v-if', 'v-else-if'])
99

10-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
10+
// eslint-disable-next-line internal/no-invalid-meta
1111
module.exports = wrapCoreRule('no-constant-condition', {
1212
create(_context, { coreHandlers }) {
1313
return {

Diff for: lib/rules/no-empty-pattern.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('no-empty-pattern')

Diff for: lib/rules/no-extra-parens.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const { isParenthesized } = require('@eslint-community/eslint-utils')
77
const { wrapCoreRule } = require('../utils')
88
const { getStyleVariablesContext } = require('../utils/style-variables')
99

10-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
10+
// eslint-disable-next-line internal/no-invalid-meta
1111
module.exports = wrapCoreRule('no-extra-parens', {
1212
skipDynamicArguments: true,
1313
applyDocument: true,

Diff for: lib/rules/no-loss-of-precision.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
const utils = require('../utils')
88

9-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
9+
// eslint-disable-next-line internal/no-invalid-meta
1010
module.exports = utils.wrapCoreRule('no-loss-of-precision', {
1111
applyDocument: true
1212
})

Diff for: lib/rules/no-restricted-syntax.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('no-restricted-syntax', {
1010
applyDocument: true
1111
})

Diff for: lib/rules/no-sparse-arrays.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('no-sparse-arrays')

Diff for: lib/rules/no-useless-concat.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('no-useless-concat', {
1010
applyDocument: true
1111
})

Diff for: lib/rules/object-curly-newline.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('object-curly-newline', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/object-curly-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('object-curly-spacing', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/object-property-newline.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('object-property-newline', {
1010
skipDynamicArguments: true
1111
})

Diff for: lib/rules/object-shorthand.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
const { wrapCoreRule } = require('../utils')
88

9-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
9+
// eslint-disable-next-line internal/no-invalid-meta
1010
module.exports = wrapCoreRule('object-shorthand', {
1111
skipDynamicArguments: true
1212
})

Diff for: lib/rules/operator-linebreak.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('operator-linebreak')

Diff for: lib/rules/prefer-template.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('prefer-template', {
1010
applyDocument: true
1111
})

Diff for: lib/rules/quote-props.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
const { wrapCoreRule, flatten } = require('../utils')
88

9-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
9+
// eslint-disable-next-line internal/no-invalid-meta
1010
module.exports = wrapCoreRule('quote-props', {
1111
skipDynamicArguments: true,
1212
preprocess(context, { wrapContextToOverrideProperties, defineVisitor }) {

Diff for: lib/rules/space-in-parens.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('space-in-parens', {
1010
skipDynamicArguments: true,
1111
skipDynamicArgumentsReport: true,

Diff for: lib/rules/space-infix-ops.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('space-infix-ops', {
1010
skipDynamicArguments: true,
1111
applyDocument: true

Diff for: lib/rules/space-unary-ops.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('space-unary-ops', {
1010
skipDynamicArguments: true,
1111
applyDocument: true

Diff for: lib/rules/template-curly-spacing.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
const { wrapCoreRule } = require('../utils')
77

8-
// eslint-disable-next-line internal/no-invalid-meta, internal/no-invalid-meta-docs-categories
8+
// eslint-disable-next-line internal/no-invalid-meta
99
module.exports = wrapCoreRule('template-curly-spacing', {
1010
skipDynamicArguments: true,
1111
applyDocument: true

Diff for: lib/utils/indent-ts.js

-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ function defineVisitor({
229229
/**
230230
* @param {ASTNode} node
231231
*/
232-
// eslint-disable-next-line complexity -- ignore
233232
'*[type=/^TS/]'(node) {
234233
if (!isTypeNode(node)) {
235234
return

0 commit comments

Comments
 (0)