Upgraded vue-eslint-parser. And remove the case of a syntax error from the target to be verified.

Author: ota-meshi

docs/rules/valid-slot-scope.md

@@ -7,8 +7,6 @@ This rule checks whether every `slot-scope` (or `scope`) attributes is valid.
 This rule reports `slot-scope` attributes in the following cases:
 
 - The `slot-scope` attribute does not have that attribute value. E.g. `<div slot-scope></div>`
-- The `slot-scope` attribute have the attribute value which is extra access to slot data. E.g. `<div slot-scope="prop, extra"></div>`
-- The `slot-scope` attribute have the attribute value which is rest parameter. E.g. `<div slot-scope="...props"></div>`
 
 This rule does not check syntax errors in directives because it's checked by [no-parsing-error] rule.
 
@@ -26,17 +24,6 @@ This rule does not check syntax errors in directives because it's checked by [no
       ...
     </template>
   </TheComponent>
-  <TheComponent>
-    <template slot-scope="a, b, c">
-      <!-- `b` and `c` are extra access. -->
-      ...
-    </template>
-  </TheComponent>
-  <TheComponent>
-    <template slot-scope="...props">
-      ...
-    </template>
-  </TheComponent>
 </template>
 ```
 

lib/rules/valid-slot-scope.js

@@ -14,15 +14,6 @@ const utils = require('../utils')
 // Helpers
 // ------------------------------------------------------------------------------
 
-/**
- * Check whether the given token is a comma.
- * @param {Token} token The token to check.
- * @returns {boolean} `true` if the token is a comma.
- */
-function isComma (token) {
-  return token != null && token.type === 'Punctuator' && token.value === ','
-}
-
 /**
  * Check whether the given token is a quote.
  * @param {Token} token The token to check.
@@ -33,28 +24,29 @@ function isQuote (token) {
 }
 
 /**
- * Gets the extra access parameter tokens of the given slot-scope node.
+ * Check whether the value of the given slot-scope node is a syntax error.
  * @param {ASTNode} node The slot-scope node to check.
  * @param {TokenStore} tokenStore The TokenStore.
- * @returns {Array} the extra tokens.
+ * @returns {boolean} `true` if the value is a syntax error
  */
-function getExtraAccessParameterTokens (node, tokenStore) {
-  const valueNode = node.value
-  const result = []
-  const valueFirstToken = tokenStore.getFirstToken(valueNode)
-  const valueLastToken = tokenStore.getLastToken(valueNode)
-  const exprLastToken = isQuote(valueFirstToken) && isQuote(valueLastToken) && valueFirstToken.value === valueLastToken.value
-    ? tokenStore.getTokenBefore(valueLastToken)
-    : valueLastToken
-  const idLastToken = tokenStore.getLastToken(valueNode.expression.id)
-  if (idLastToken !== exprLastToken) {
-    // e.g. `<div slot-scope="a, b">`
-    //                         ^^^ Invalid
-    result.push(...tokenStore.getTokensBetween(idLastToken, exprLastToken))
-    result.push(exprLastToken)
+function isSyntaxError (node, tokenStore) {
+  if (node.value == null) {
+    // does not have value.
+    return false
   }
-
-  return result
+  if (node.value.expression != null) {
+    return false
+  }
+  const tokens = tokenStore.getTokens(node.value)
+  if (!tokens.length) {
+    // empty value
+    return false
+  }
+  if (tokens.length === 2 && tokens.every(isQuote)) {
+    // empty value e.g `""` / `''`
+    return false
+  }
+  return true
 }
 
 // ------------------------------------------------------------------------------
@@ -71,10 +63,7 @@ module.exports = {
     fixable: null,
     schema: [],
     messages: {
-      expectedValue: "'{{attrName}}' attributes require a value.",
-      unexpectedRestParameter: 'The top level rest parameter is useless.',
-      unexpectedExtraAccessParams: 'Unexpected extra access parameters `{{value}}`.',
-      unexpectedTrailingComma: 'Unexpected trailing comma.'
+      expectedValue: "'{{attrName}}' attributes require a value."
     }
   },
 
@@ -85,51 +74,16 @@ module.exports = {
     return utils.defineTemplateBodyVisitor(context, {
       'VAttribute[directive=true][key.name=/^(slot-)?scope$/]' (node) {
         if (!utils.hasAttributeValue(node)) {
+          if (isSyntaxError(node, tokenStore)) {
+            // syntax error
+            return
+          }
           context.report({
             node,
             loc: node.loc,
             messageId: 'expectedValue',
             data: { attrName: node.key.name }
           })
-          return
-        }
-
-        const idNode = node.value.expression.id
-        if (idNode.type === 'RestElement') {
-          // e.g. `<div slot-scope="...a">`
-          context.report({
-            node: idNode,
-            loc: idNode.loc,
-            messageId: 'unexpectedRestParameter'
-          })
-        }
-
-        const extraAccessParameterTokens = getExtraAccessParameterTokens(node, tokenStore)
-        if (extraAccessParameterTokens.length) {
-          const startToken = extraAccessParameterTokens[0]
-          if (extraAccessParameterTokens.length === 1 && isComma(startToken)) {
-            context.report({
-              node: startToken,
-              loc: startToken.loc,
-              messageId: 'unexpectedTrailingComma'
-            })
-          } else {
-            const endToken = extraAccessParameterTokens[extraAccessParameterTokens.length - 1]
-            const value = context.getSourceCode().text.slice(
-              extraAccessParameterTokens.length > 1 && isComma(startToken)
-                ? extraAccessParameterTokens[1].range[0]
-                : startToken.range[0],
-              endToken.range[1]
-            )
-            context.report({
-              loc: {
-                start: startToken.loc.start,
-                end: endToken.loc.end
-              },
-              messageId: 'unexpectedExtraAccessParams',
-              data: { value }
-            })
-          }
         }
       }
     })

package.json

@@ -44,7 +44,7 @@
     "eslint": "^5.0.0"
   },
   "dependencies": {
-    "vue-eslint-parser": "^3.2.1"
+    "vue-eslint-parser": "^3.3.0"
   },
   "devDependencies": {
     "@types/node": "^4.2.16",