Exclude with dynamic arguments from core rule wrapper validation target

Author: ota-meshi

lib/rules/array-bracket-spacing.js

@@ -5,5 +5,8 @@
 
 const { wrapCoreRule } = require('../utils')
 
-// eslint-disable-next-line
-module.exports = wrapCoreRule(require('eslint/lib/rules/array-bracket-spacing'))
+// eslint-disable-next-line no-invalid-meta
+module.exports = wrapCoreRule(
+  require('eslint/lib/rules/array-bracket-spacing'),
+  { skipDynamicArguments: true }
+)

lib/utils/index.js

@@ -65,10 +65,13 @@ module.exports = {
   /**
    * Wrap a given core rule to apply it to Vue.js template.
    * @param {Rule} coreRule The core rule implementation to wrap.
-   * @param {string|undefined} category The category of this rule.
+   * @param {Object|undefined} options The option of this rule.
+   * @param {string|undefined} options.category The category of this rule.
+   * @param {boolean|undefined} options.skipDynamicArguments If `true`, skip validation within dynamic arguments.
    * @returns {Rule} The wrapped rule implementation.
    */
-  wrapCoreRule (coreRule, category) {
+  wrapCoreRule (coreRule, options) {
+    const { category, skipDynamicArguments } = options || {}
     return {
       create (context) {
         const tokenStore =
@@ -92,6 +95,19 @@ module.exports = {
           delete handlers['Program:exit']
         }
 
+        if (skipDynamicArguments) {
+          let withinDynamicArguments = false
+          for (const name of Object.keys(handlers)) {
+            const original = handlers[name]
+            handlers[name] = (...args) => {
+              if (withinDynamicArguments) return
+              original(...args)
+            }
+          }
+          handlers['VDirectiveKey > VExpressionContainer'] = () => { withinDynamicArguments = true }
+          handlers['VDirectiveKey > VExpressionContainer:exit'] = () => { withinDynamicArguments = false }
+        }
+
         // Apply the handlers to templates.
         return module.exports.defineTemplateBodyVisitor(context, handlers)
       },

tests/lib/rules/array-bracket-spacing.js

@@ -21,6 +21,16 @@ tester.run('array-bracket-spacing', rule, {
     {
       code: '<template><div :attr="[ a ]" /></template>',
       options: ['always']
+    },
+    '<template><div :[attr]="a" /></template>',
+    {
+      code: '<template><div :[attr]="a" /></template>',
+      options: ['always']
+    },
+    '<template><div :[[attr]]="a" /></template>',
+    {
+      code: '<template><div :[[attr]]="a" /></template>',
+      options: ['always']
     }
   ],
   invalid: [