Change options schema to strictly. (#1430)

ota-meshi · web-flow · commit 47e3f89a554a · 2021-02-04T09:05:30.000+09:00
diff --git a/lib/rules/attributes-order.js b/lib/rules/attributes-order.js
@@ -367,18 +367,33 @@ module.exports = {
       url: 'https://eslint.vuejs.org/rules/attributes-order.html'
     },
     fixable: 'code',
-    schema: {
-      type: 'array',
-      properties: {
-        order: {
-          items: {
-            type: 'string'
+    schema: [
+      {
+        type: 'object',
+        properties: {
+          order: {
+            type: 'array',
+            items: {
+              anyOf: [
+                { enum: Object.values(ATTRS) },
+                {
+                  type: 'array',
+                  items: {
+                    enum: Object.values(ATTRS),
+                    uniqueItems: true,
+                    additionalItems: false
+                  }
+                }
+              ]
+            },
+            uniqueItems: true,
+            additionalItems: false
           },
-          maxItems: 10,
-          minItems: 10
-        }
+          alphabetical: { type: 'boolean' }
+        },
+        additionalProperties: false
       }
-    }
+    ]
   },
   create
 }
diff --git a/lib/rules/component-tags-order.js b/lib/rules/component-tags-order.js
@@ -40,7 +40,8 @@ module.exports = {
             uniqueItems: true,
             additionalItems: false
           }
-        }
+        },
+        additionalProperties: false
       }
     ],
     messages: {
diff --git a/lib/rules/max-attributes-per-line.js b/lib/rules/max-attributes-per-line.js
@@ -61,7 +61,8 @@ module.exports = {
               }
             ]
           }
-        }
+        },
+        additionalProperties: false
       }
     ]
   },
diff --git a/lib/rules/new-line-between-multi-line-property.js b/lib/rules/new-line-between-multi-line-property.js
@@ -68,7 +68,8 @@ module.exports = {
             type: 'number',
             minimum: 2
           }
-        }
+        },
+        additionalProperties: false
       }
     ]
   },
diff --git a/lib/rules/no-bare-strings-in-template.js b/lib/rules/no-bare-strings-in-template.js
@@ -149,7 +149,8 @@ module.exports = {
             items: { type: 'string', pattern: '^v-' },
             uniqueItems: true
           }
-        }
+        },
+        additionalProperties: false
       }
     ],
     messages: {
diff --git a/lib/rules/no-duplicate-attributes.js b/lib/rules/no-duplicate-attributes.js
@@ -59,7 +59,8 @@ module.exports = {
           allowCoexistStyle: {
             type: 'boolean'
           }
-        }
+        },
+        additionalProperties: false
       }
     ]
   },
diff --git a/lib/rules/no-potential-component-option-typo.js b/lib/rules/no-potential-component-option-typo.js
@@ -44,7 +44,8 @@ module.exports = {
             type: 'number',
             minimum: 1
           }
-        }
+        },
+        additionalProperties: false
       }
     ]
   },
diff --git a/lib/rules/no-reserved-component-names.js b/lib/rules/no-reserved-component-names.js
@@ -84,7 +84,8 @@ module.exports = {
           disallowVue3BuiltInComponents: {
             type: 'boolean'
           }
-        }
+        },
+        additionalProperties: false
       }
     ],
     messages: {
diff --git a/lib/rules/no-use-v-if-with-v-for.js b/lib/rules/no-use-v-if-with-v-for.js
@@ -62,7 +62,8 @@ module.exports = {
           allowUsingIterationVar: {
             type: 'boolean'
           }
-        }
+        },
+        additionalProperties: false
       }
     ]
   },
diff --git a/lib/rules/no-useless-mustaches.js b/lib/rules/no-useless-mustaches.js
@@ -50,7 +50,8 @@ module.exports = {
           ignoreStringEscape: {
             type: 'boolean'
           }
-        }
+        },
+        additionalProperties: false
       }
     ],
     type: 'suggestion'
diff --git a/lib/rules/no-useless-v-bind.js b/lib/rules/no-useless-v-bind.js
@@ -30,7 +30,8 @@ module.exports = {
           ignoreStringEscape: {
             type: 'boolean'
           }
-        }
+        },
+        additionalProperties: false
       }
     ],
     type: 'suggestion'
diff --git a/lib/rules/valid-v-slot.js b/lib/rules/valid-v-slot.js
@@ -287,7 +287,8 @@ module.exports = {
           allowModifiers: {
             type: 'boolean'
           }
-        }
+        },
+        additionalProperties: false
       }
     ],
     messages: {
diff --git a/tests/lib/rules/attributes-order.js b/tests/lib/rules/attributes-order.js
@@ -259,7 +259,7 @@ tester.run('attributes-order', rule, {
           <div
             v-if="!visible"
             class="content"
-            :class="className"
+            v-model="foo"
             v-text="textContent"
             >
           </div>
@@ -273,7 +273,7 @@ tester.run('attributes-order', rule, {
             'DEFINITION',
             'EVENTS',
             'UNIQUE',
-            ['BINDING', 'OTHER_ATTR'],
+            ['TWO_WAY_BINDING', 'OTHER_ATTR'],
             'CONTENT',
             'GLOBAL'
           ]
@@ -719,7 +719,7 @@ tester.run('attributes-order', rule, {
             <div
               class="content"
               v-if="!visible"
-              :class="className"
+              v-model="foo"
               v-text="textContent"
               >
             </div>
@@ -733,7 +733,7 @@ tester.run('attributes-order', rule, {
             'DEFINITION',
             'EVENTS',
             'UNIQUE',
-            ['BINDING', 'OTHER_ATTR'],
+            ['TWO_WAY_BINDING', 'OTHER_ATTR'],
             'CONTENT',
             'GLOBAL'
           ]
@@ -743,7 +743,7 @@ tester.run('attributes-order', rule, {
             <div
               v-if="!visible"
               class="content"
-              :class="className"
+              v-model="foo"
               v-text="textContent"
               >
             </div>

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,8 @@ module.exports = {`
`40`	`40`	`uniqueItems: true,`
`41`	`41`	`additionalItems: false`
`42`	`42`	`}`
`43`		`- }`
	`43`	`+ },`
	`44`	`+ additionalProperties: false`
`44`	`45`	`}`
`45`	`46`	`],`
`46`	`47`	`messages: {`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,8 @@ module.exports = {`
`61`	`61`	`}`
`62`	`62`	`]`
`63`	`63`	`}`
`64`		`- }`
	`64`	`+ },`
	`65`	`+ additionalProperties: false`
`65`	`66`	`}`
`66`	`67`	`]`
`67`	`68`	`},`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,8 @@ module.exports = {`
`68`	`68`	`type: 'number',`
`69`	`69`	`minimum: 2`
`70`	`70`	`}`
`71`		`- }`
	`71`	`+ },`
	`72`	`+ additionalProperties: false`
`72`	`73`	`}`
`73`	`74`	`]`
`74`	`75`	`},`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,8 @@ module.exports = {`
`149`	`149`	`items: { type: 'string', pattern: '^v-' },`
`150`	`150`	`uniqueItems: true`
`151`	`151`	`}`
`152`		`- }`
	`152`	`+ },`
	`153`	`+ additionalProperties: false`
`153`	`154`	`}`
`154`	`155`	`],`
`155`	`156`	`messages: {`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,8 @@ module.exports = {`
`59`	`59`	`allowCoexistStyle: {`
`60`	`60`	`type: 'boolean'`
`61`	`61`	`}`
`62`		`- }`
	`62`	`+ },`
	`63`	`+ additionalProperties: false`
`63`	`64`	`}`
`64`	`65`	`]`
`65`	`66`	`},`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@ module.exports = {`
`44`	`44`	`type: 'number',`
`45`	`45`	`minimum: 1`
`46`	`46`	`}`
`47`		`- }`
	`47`	`+ },`
	`48`	`+ additionalProperties: false`
`48`	`49`	`}`
`49`	`50`	`]`
`50`	`51`	`},`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,8 @@ module.exports = {`
`84`	`84`	`disallowVue3BuiltInComponents: {`
`85`	`85`	`type: 'boolean'`
`86`	`86`	`}`
`87`		`- }`
	`87`	`+ },`
	`88`	`+ additionalProperties: false`
`88`	`89`	`}`
`89`	`90`	`],`
`90`	`91`	`messages: {`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,8 @@ module.exports = {`
`62`	`62`	`allowUsingIterationVar: {`
`63`	`63`	`type: 'boolean'`
`64`	`64`	`}`
`65`		`- }`
	`65`	`+ },`
	`66`	`+ additionalProperties: false`
`66`	`67`	`}`
`67`	`68`	`]`
`68`	`69`	`},`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,8 @@ module.exports = {`
`50`	`50`	`ignoreStringEscape: {`
`51`	`51`	`type: 'boolean'`
`52`	`52`	`}`
`53`		`- }`
	`53`	`+ },`
	`54`	`+ additionalProperties: false`
`54`	`55`	`}`
`55`	`56`	`],`
`56`	`57`	`type: 'suggestion'`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,8 @@ module.exports = {`
`30`	`30`	`ignoreStringEscape: {`
`31`	`31`	`type: 'boolean'`
`32`	`32`	`}`
`33`		`- }`
	`33`	`+ },`
	`34`	`+ additionalProperties: false`
`34`	`35`	`}`
`35`	`36`	`],`
`36`	`37`	`type: 'suggestion'`