Implement rule

Author: armano2

lib/rules/no-extra-space-between-attributes.js

@@ -4,6 +4,12 @@
  */
 'use strict'
 
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+const utils = require('../utils')
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -21,21 +27,34 @@ module.exports = {
     ]
   },
 
+  /**
+   * @param {RuleContext} context - The rule context.
+   * @returns {Object} AST event handlers.
+   */
   create (context) {
-    // variables should be defined here
-
-    // ----------------------------------------------------------------------
-    // Helpers
-    // ----------------------------------------------------------------------
-
-    // any helper functions should go here or else delete this section
+    const sourceCode = context.getSourceCode()
 
     // ----------------------------------------------------------------------
     // Public
     // ----------------------------------------------------------------------
 
-    return {
-      // give me methods
-    }
+    utils.registerTemplateBodyVisitor(context, {
+      VStartTag (node) {
+        const text = sourceCode.getText(node)
+        const newText = text
+          .replace(/([^\r\n\t\s])([ \t]+)/g, '$1 ')
+          .replace(/([ \t]*)([\r\n]+)/, '$2')
+        if (text !== newText) {
+          context.report({
+            node,
+            loc: node.loc,
+            message: 'Extra whitespace detected.',
+            fix: (fixer) => fixer.replaceText(node, newText)
+          })
+        }
+      }
+    })
+
+    return { }
   }
 }

tests/lib/rules/no-extra-space-between-attributes.js

@@ -24,22 +24,39 @@ ruleTester.run('no-extra-space-between-attributes', rule, {
   valid: [
     {
       filename: 'test.vue',
-      code: `
-      <template>
-        <div></div>
-        <div />
-        <div class="foo"></div>
-        <div class="foo" @click="bar"></div>
-        <div class="foo"></div>
-        <div class="foo"
-        :style="foo"></div>
-        <div class="foo"
-        :style="foo"
-        ></div>
-        <div class="foo"
-        :style="foo" />
-      </template>
-      `
+      code: '<template></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div /></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div class="foo"></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div class="foo" @click="bar"></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div class="foo"\n          :style="foo"></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div class="foo"\n      :style="foo"\n      ></div></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div class="foo"\n                       :style="foo" /></template>'
+    },
+    {
+      filename: 'test.vue',
+      code: '<template><div class="foo"\n                       :style="foo"\n                            /></template>'
     }
   ],
 
@@ -49,57 +66,66 @@ ruleTester.run('no-extra-space-between-attributes', rule, {
       output: '<template><div /></template>',
       errors: [{
         message: 'Extra whitespace detected.',
-        type: 'VText'
+        type: 'VStartTag'
       }]
     },
     {
       code: '<template><div   class="foo"  /></template>',
       output: '<template><div class="foo" /></template>',
-      errors: [{
-        message: 'Extra whitespace detected.',
-        type: 'VText'
-      }, {
-        message: 'Extra whitespace detected.',
-        type: 'VText'
-      }]
+      errors: [
+        // {
+        //   message: 'Extra whitespace detected.',
+        //   type: 'VStartTag'
+        // },
+        {
+          message: 'Extra whitespace detected.',
+          type: 'VStartTag'
+        }
+      ]
     },
     {
       code: '<template><div   :class="foo"  /></template>',
       output: '<template><div :class="foo" /></template>',
-      errors: [{
-        message: 'Extra whitespace detected.',
-        type: 'VText'
-      }, {
-        message: 'Extra whitespace detected.',
-        type: 'VText'
-      }]
+      errors: [
+        // {
+        //   message: 'Extra whitespace detected.',
+        //   type: 'VStartTag'
+        // },
+        {
+          message: 'Extra whitespace detected.',
+          type: 'VStartTag'
+        }
+      ]
     },
     {
       code: '<template><div foo="" class="foo"  /></template>',
       output: '<template><div foo="" class="foo" /></template>',
       errors: [{
         message: 'Extra whitespace detected.',
-        type: 'VText'
+        type: 'VStartTag'
       }]
     },
     {
       code: '<template><div v-foo="" class="foo"  /></template>',
       output: '<template><div v-foo="" class="foo" /></template>',
       errors: [{
         message: 'Extra whitespace detected.',
-        type: 'VText'
+        type: 'VStartTag'
       }]
     },
     {
       code: '<template><div v-foo="" \n         class="foo"  /></template>',
       output: '<template><div v-foo=""\n         class="foo" /></template>',
-      errors: [{
-        message: 'Extra whitespace detected.',
-        type: 'VText'
-      }, {
-        message: 'Extra whitespace detected.',
-        type: 'VText'
-      }]
+      errors: [
+        // {
+        //   message: 'Extra whitespace detected.',
+        //   type: 'VStartTag'
+        // },
+        {
+          message: 'Extra whitespace detected.',
+          type: 'VStartTag'
+        }
+      ]
     }
   ]
 })