provide suggestions instead of auto fix

Author: g-plane

lib/rules/prefer-true-attribute-shorthand.js

@@ -31,7 +31,11 @@ module.exports = {
         "Boolean prop with 'true' value should be written in shorthand form.",
       expectLong:
         "Boolean prop with 'true' value should be written in long form.",
-      suggestion: 'Rewrite this prop into shorthand form.'
+      rewriteIntoShort: 'Rewrite this prop into shorthand form.',
+      rewriteIntoLongVueProp:
+        'Rewrite this prop into long-form Vue component prop.',
+      rewriteIntoLongHtmlAttr:
+        'Rewrite this prop into long-form HTML attribute.'
     }
   },
   /** @param {RuleContext} context */
@@ -49,8 +53,21 @@ module.exports = {
           context.report({
             node,
             messageId: 'expectLong',
-            fix: (fixer) =>
-              fixer.replaceText(node, `:${node.key.rawName}="true"`)
+            suggest: [
+              {
+                messageId: 'rewriteIntoLongVueProp',
+                fix: (fixer) =>
+                  fixer.replaceText(node, `:${node.key.rawName}="true"`)
+              },
+              {
+                messageId: 'rewriteIntoLongHtmlAttr',
+                fix: (fixer) =>
+                  fixer.replaceText(
+                    node,
+                    `${node.key.rawName}="${node.key.rawName}"`
+                  )
+              }
+            ]
           })
           return
         }
@@ -79,7 +96,7 @@ module.exports = {
           messageId: 'expectShort',
           suggest: [
             {
-              messageId: 'suggestion',
+              messageId: 'rewriteIntoShort',
               fix: (fixer) => {
                 const sourceCode = context.getSourceCode()
                 return fixer.replaceText(node, sourceCode.getText(argument))

tests/lib/rules/prefer-true-attribute-shorthand.js

@@ -164,7 +164,7 @@ tester.run('prefer-true-attribute-shorthand', rule, {
           column: 17,
           suggestions: [
             {
-              messageId: 'suggestion',
+              messageId: 'rewriteIntoShort',
               output: `
       <template>
         <MyComp show />
@@ -188,7 +188,7 @@ tester.run('prefer-true-attribute-shorthand', rule, {
           column: 17,
           suggestions: [
             {
-              messageId: 'suggestion',
+              messageId: 'rewriteIntoShort',
               output: `
       <template>
         <MyComp show />
@@ -213,7 +213,7 @@ tester.run('prefer-true-attribute-shorthand', rule, {
           column: 17,
           suggestions: [
             {
-              messageId: 'suggestion',
+              messageId: 'rewriteIntoShort',
               output: `
       <template>
         <MyComp show />
@@ -238,7 +238,7 @@ tester.run('prefer-true-attribute-shorthand', rule, {
           column: 17,
           suggestions: [
             {
-              messageId: 'suggestion',
+              messageId: 'rewriteIntoShort',
               output: `
       <template>
         <MyComp show />
@@ -260,13 +260,24 @@ tester.run('prefer-true-attribute-shorthand', rule, {
         {
           messageId: 'expectLong',
           line: 3,
-          column: 17
-        }
-      ],
-      output: `
+          column: 17,
+          suggestions: [
+            {
+              output: `
       <template>
         <MyComp :show="true" />
       </template>`
+            },
+            {
+              output: `
+      <template>
+        <MyComp show="show" />
+      </template>`
+            }
+          ]
+        }
+      ],
+      output: null
     }
   ]
 })