Fix false positives for import binding in vue/valid-define-emits and vue/valid-define-props rules (#1736)

* Fix false positives for import binding in `vue/valid-define-emits` and `vue/valid-define-props` rules

* Apply suggestions from code review

Co-authored-by: Flo Edelmann <[email protected]>

* fix

Co-authored-by: Flo Edelmann <[email protected]>

Author: ota-meshi

lib/rules/valid-define-emits.js

@@ -79,6 +79,7 @@ module.exports = {
                   variable.defs.length &&
                   variable.defs.every(
                     (def) =>
+                      def.type !== 'ImportBinding' &&
                       utils.inRange(scriptSetup.range, def.name) &&
                       !utils.inRange(defineEmits.range, def.name)
                   )

lib/rules/valid-define-props.js

@@ -80,6 +80,7 @@ module.exports = {
                   variable.defs.length &&
                   variable.defs.every(
                     (def) =>
+                      def.type !== 'ImportBinding' &&
                       utils.inRange(scriptSetup.range, def.name) &&
                       !utils.inRange(defineProps.range, def.name)
                   )

tests/lib/rules/valid-define-emits.js

@@ -117,6 +117,16 @@ tester.run('valid-define-emits', rule, {
       });
       </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      import { propsDef, emitsDef } from './defs';
+
+      defineProps(propsDef);
+      defineEmits(emitsDef);
+      </script>`
     }
   ],
   invalid: [

tests/lib/rules/valid-define-props.js

@@ -120,6 +120,16 @@ tester.run('valid-define-props', rule, {
       });
       </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+      <script setup>
+      import { propsDef, emitsDef } from './defs';
+
+      defineProps(propsDef);
+      defineEmits(emitsDef);
+      </script>`
     }
   ],
   invalid: [