Skip to content

Being able to disable Component Events (or any other timeline) #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
posva opened this issue Aug 23, 2021 · 4 comments
Closed

Being able to disable Component Events (or any other timeline) #1545

posva opened this issue Aug 23, 2021 · 4 comments

Comments

@posva
Copy link
Member

posva commented Aug 23, 2021

Some components emit too many events and make it difficult to inspect the timeline. It would be nice if, in v6, it was possible to disable any of the timelines like we can with the performance one, right from the timeline:

Screenshot 2021-08-23 at 15 21 51

One of the most common examples is applications using map components. They emit a lot of events and it becomes laggy quite quickly (after moving the map around, the timeline can take up to +30s to charge), making it hard to debug any other timeline.

This was possible in v5 with the small record button, to stop tracking component events.

@Akryum
Copy link
Member

Akryum commented Aug 23, 2021

Did you try hiding the layer? Is it still taking a performance hit?

@posva
Copy link
Member Author

posva commented Aug 23, 2021

I completely forgot you could hide them! It reduces the time a bit but it still takes about 10s to load.

@Akryum
Copy link
Member

Akryum commented Aug 23, 2021

Maybe the improvement would be to prevent sending the events over the wire when the layer isn't visible and then fetch the layer again when it's toggled

@posva
Copy link
Member Author

posva commented Aug 23, 2021

I would say that completely dropping the events to avoid any memory increase could be better.

I still think having a button directly on the timeline is more intuitive than the list button to toggle. I always forget it exists!

@Akryum Akryum closed this as completed in 4bd91cf Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants