Skip to content

Commit deb5f0e

Browse files
committed
fix: build electron using NODE_ENV=production + silice bridge logs in production, closes #1151
1 parent 64889dc commit deb5f0e

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/shell-chrome/src/background.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function installProxy (tabId) {
3939
if (!res) {
4040
ports[tabId].devtools.postMessage('proxy-fail')
4141
} else {
42-
console.log('injected proxy to tab ' + tabId)
42+
if (process.env.NODE_ENV !== 'production') { console.log('injected proxy to tab ' + tabId) }
4343
}
4444
})
4545
}
@@ -50,19 +50,19 @@ function doublePipe (id, one, two) {
5050
if (message.event === 'log') {
5151
return console.log('tab ' + id, message.payload)
5252
}
53-
console.log('devtools -> backend', message)
53+
if (process.env.NODE_ENV !== 'production') { console.log('devtools -> backend', message) }
5454
two.postMessage(message)
5555
}
5656
two.onMessage.addListener(lTwo)
5757
function lTwo (message) {
5858
if (message.event === 'log') {
5959
return console.log('tab ' + id, message.payload)
6060
}
61-
console.log('backend -> devtools', message)
61+
if (process.env.NODE_ENV !== 'production') { console.log('backend -> devtools', message) }
6262
one.postMessage(message)
6363
}
6464
function shutdown () {
65-
console.log('tab ' + id + ' disconnected.')
65+
if (process.env.NODE_ENV !== 'production') { console.log('tab ' + id + ' disconnected.') }
6666
one.onMessage.removeListener(lOne)
6767
two.onMessage.removeListener(lTwo)
6868
one.disconnect()
@@ -71,7 +71,7 @@ function doublePipe (id, one, two) {
7171
}
7272
one.onDisconnect.addListener(shutdown)
7373
two.onDisconnect.addListener(shutdown)
74-
console.log('tab ' + id + ' connected.')
74+
if (process.env.NODE_ENV !== 'production') { console.log('tab ' + id + ' connected.') }
7575
}
7676

7777
chrome.runtime.onMessage.addListener((req, sender) => {

packages/shell-electron/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"scripts": {
1616
"start": "node bin.js",
1717
"dev": "webpack --watch",
18-
"build": "rm -rf ./build && webpack",
18+
"build": "rm -rf ./build && cross-env NODE_ENV=production webpack",
1919
"prepublishOnly": "npm run build"
2020
},
2121
"author": "",

0 commit comments

Comments
 (0)