Skip to content

Commit c3c183f

Browse files
author
Guillaume Chau
authored
Escape HTML for more data (#573)
* More html examples * Escape function name * Escape native objects display
1 parent 1761b9a commit c3c183f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

shells/dev/target/NativeTypes.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,9 @@ export default {
7777
largeArray: [],
7878
i: new Set([1, 2, 3, 4, new Set([5, 6, 7, 8]), new Map([[1, 2], [3, 4], [5, new Map([[6, 7]])]])]),
7979
j: new Map([[1, 2], [3, 4], [5, new Map([[6, 7]])], [8, new Set([1, 2, 3, 4, new Set([5, 6, 7, 8]), new Map([[1, 2], [3, 4], [5, new Map([[6, 7]])]])])]]),
80-
html: '<b>Bold</b> <i>Italic</i>'
80+
html: '<b>Bold</b> <i>Italic</i>',
81+
htmlReg: /<b>hey<\/b>/i,
82+
'html <b>key</b>': (h, t, m, l) => {}
8183
}
8284
},
8385
computed: {

src/devtools/components/DataField.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,11 +280,11 @@ export default {
280280
} else if (this.valueType === 'plain-object') {
281281
return 'Object' + (Object.keys(value).length ? '' : ' (empty)')
282282
} else if (this.valueType.includes('native')) {
283-
return specialTypeRE.exec(value)[2]
283+
return escape(specialTypeRE.exec(value)[2])
284284
} else if (typeof value === 'string') {
285285
var typeMatch = value.match(rawTypeRE)
286286
if (typeMatch) {
287-
return typeMatch[1]
287+
return escape(typeMatch[1])
288288
} else {
289289
return `<span>"</span>${escape(value)}<span>"</span>`
290290
}

src/util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ export function getCustomFunctionDetails (func) {
236236
return {
237237
_custom: {
238238
type: 'function',
239-
display: `<span>ƒ</span> ${func.name}${args}`
239+
display: `<span>ƒ</span> ${escape(func.name)}${args}`
240240
}
241241
}
242242
}

0 commit comments

Comments
 (0)