Fix inject problems (#385)

* inject: prevent global variable 'script'

Once the Vue panel is open, a variable window.script appears with the
injected script tag. Fix it by wrapping it in an anonymous function.

* Only inject script if document is a HTMLDocument

Fixes #356

Author: dr-itz

shells/chrome/src/detector.js

@@ -28,7 +28,9 @@ function detect (win) {
 }
 
 // inject the hook
-const script = document.createElement('script')
-script.textContent = ';(' + detect.toString() + ')(window)'
-document.documentElement.appendChild(script)
-script.parentNode.removeChild(script)
+if (document instanceof HTMLDocument) {
+  const script = document.createElement('script')
+  script.textContent = ';(' + detect.toString() + ')(window)'
+  document.documentElement.appendChild(script)
+  script.parentNode.removeChild(script)
+}

shells/chrome/src/devtools.js

@@ -59,10 +59,12 @@ initDevTools({
 
 function injectScript (scriptName, cb) {
   const src = `
-    var script = document.constructor.prototype.createElement.call(document, 'script');
-    script.src = "${scriptName}";
-    document.documentElement.appendChild(script);
-    script.parentNode.removeChild(script);
+    (function() {
+      var script = document.constructor.prototype.createElement.call(document, 'script');
+      script.src = "${scriptName}";
+      document.documentElement.appendChild(script);
+      script.parentNode.removeChild(script);
+    })()
   `
   chrome.devtools.inspectedWindow.eval(src, function (res, err) {
     if (err) {

shells/chrome/src/hook.js

@@ -2,7 +2,9 @@
 import { installHook } from 'src/backend/hook'
 
 // inject the hook
-const script = document.createElement('script')
-script.textContent = ';(' + installHook.toString() + ')(window)'
-document.documentElement.appendChild(script)
-script.parentNode.removeChild(script)
+if (document instanceof HTMLDocument) {
+  const script = document.createElement('script')
+  script.textContent = ';(' + installHook.toString() + ')(window)'
+  document.documentElement.appendChild(script)
+  script.parentNode.removeChild(script)
+}