Skip to content

Commit 3f70260

Browse files
author
Guillaume Chau
committed
fix(vuex): wrap getters in custom store details too
1 parent 895f5ca commit 3f70260

File tree

1 file changed

+24
-20
lines changed

1 file changed

+24
-20
lines changed

packages/app-backend/src/vuex.js

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -340,27 +340,9 @@ class VuexBackend {
340340
}
341341

342342
stringifyStore () {
343-
const getters = {}
344-
345-
const origGetters = this.store.getters || {}
346-
const keys = Object.keys(origGetters)
347-
for (let i = 0; i < keys.length; i++) {
348-
const key = keys[i]
349-
Object.defineProperty(getters, key, {
350-
enumerable: true,
351-
get: () => {
352-
try {
353-
return origGetters[key]
354-
} catch (e) {
355-
return e
356-
}
357-
}
358-
})
359-
}
360-
361343
return stringify({
362344
state: this.store.state,
363-
getters
345+
getters: getCatchedGetters(this.store)
364346
})
365347
}
366348

@@ -597,14 +579,36 @@ export function initVuexBackend (hook, bridge, isLegacy) {
597579
new VuexBackend(hook, bridge, isLegacy)
598580
}
599581

582+
function getCatchedGetters (store) {
583+
const getters = {}
584+
585+
const origGetters = store.getters || {}
586+
const keys = Object.keys(origGetters)
587+
for (let i = 0; i < keys.length; i++) {
588+
const key = keys[i]
589+
Object.defineProperty(getters, key, {
590+
enumerable: true,
591+
get: () => {
592+
try {
593+
return origGetters[key]
594+
} catch (e) {
595+
return e
596+
}
597+
}
598+
})
599+
}
600+
601+
return getters
602+
}
603+
600604
export function getCustomStoreDetails (store) {
601605
return {
602606
_custom: {
603607
type: 'store',
604608
display: 'Store',
605609
value: {
606610
state: store.state,
607-
getters: store.getters
611+
getters: getCatchedGetters(store)
608612
},
609613
fields: {
610614
abstract: true

0 commit comments

Comments
 (0)