Skip to content

Commit f0e47a6

Browse files
committed
fix: set moduleResolution: Bundler in tsconfig.node.json
It was `moduleResolution: "node"` in `@tsconfig/node18` v2, but later changed to `node16` in v18. This is a breaking change, and not suitable for our use cases. We use the Node.js tsconfig for configuration files, most of which expect either `moduleResolution: "node"` or `moduleResolution: "bundler"` (e.g. Vite, which has its own bundling logic for configuration file). So in the commit, I'm setting it to `moduleResolution: "bundler"`. I haven't seen any regressions myself, but if there are any, we can revert to `moduleResolution: "node"`. `node16` is obviously not compatible with many tools at the moment.
1 parent 3bd9773 commit f0e47a6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: template/tsconfig/base/tsconfig.node.json

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"compilerOptions": {
1111
"composite": true,
1212
"module": "ESNext",
13+
"moduleResolution": "Bundler",
1314
"types": ["node"]
1415
}
1516
}

0 commit comments

Comments
 (0)