Skip to content

Commit 9b27fdf

Browse files
authored
fix: use --build for type-checking to be exhaustive and less-fragile (#274)
1 parent 95a7052 commit 9b27fdf

File tree

10 files changed

+13
-50
lines changed

10 files changed

+13
-50
lines changed

Diff for: pnpm-lock.yaml

+4-40
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: template/base/_gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,5 @@ coverage
2626
*.njsproj
2727
*.sln
2828
*.sw?
29+
30+
*.tsbuildinfo

Diff for: template/config/nightwatch/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
"@types/nightwatch": "^2.3.30",
1010
"geckodriver": "^4.2.1",
1111
"chromedriver": "^119.0.0",
12-
"ts-node": "^10.9.1"
12+
"ts-node": "^10.9.1",
13+
"vite-plugin-nightwatch": "^0.4.5"
1314
}
1415
}

Diff for: template/config/typescript/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"scripts": {
33
"build": "run-p type-check \"build-only {@}\" --",
44
"build-only": "vite build",
5-
"type-check": "vue-tsc --noEmit -p tsconfig.app.json --composite false"
5+
"type-check": "vue-tsc --build --force"
66
},
77
"devDependencies": {
88
"@types/node": "^18.18.13",

Diff for: template/tsconfig/base/tsconfig.app.json

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"exclude": ["src/**/__tests__/*"],
55
"compilerOptions": {
66
"composite": true,
7+
"noEmit": true,
78
"baseUrl": ".",
89
"paths": {
910
"@/*": ["./src/*"]

Diff for: template/tsconfig/base/tsconfig.node.json

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
],
1010
"compilerOptions": {
1111
"composite": true,
12+
"noEmit": true,
1213
"module": "ESNext",
1314
"moduleResolution": "Bundler",
1415
"types": ["node"]

Diff for: template/tsconfig/cypress-ct/package.json

-5
This file was deleted.

Diff for: template/tsconfig/nightwatch-ct/tsconfig.app.json

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"exclude": ["src/**/__tests__/*"],
55
"compilerOptions": {
66
"composite": true,
7+
"noEmit": true,
78
"baseUrl": ".",
89
"paths": {
910
"@/*": ["./src/*"]

Diff for: template/tsconfig/nightwatch/nightwatch/tsconfig.json

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"module": "commonjs",
66
"moduleResolution": "node",
77
"composite": true,
8+
"noEmit": true,
89
"rootDir": "../",
910
"lib": ["ESNext", "dom"],
1011
"types": ["nightwatch"]

Diff for: template/tsconfig/vitest/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
{
2-
"scripts": {
3-
"type-check": "vue-tsc --noEmit -p tsconfig.vitest.json --composite false"
4-
},
52
"devDependencies": {
63
"@types/jsdom": "^21.1.6"
74
}

0 commit comments

Comments
 (0)