fix(devtools): clear devtools buffer after timeout

yyx990803 · yyx990803 · commit f4639e0a36ab · 2021-10-07T19:36:32.000-04:00
fix #4738
diff --git a/packages/runtime-core/src/devtools.ts b/packages/runtime-core/src/devtools.ts
@@ -53,6 +53,11 @@ export function setDevtoolsHook(hook: DevtoolsHook, target: any) {
     replay.push((newHook: DevtoolsHook) => {
       setDevtoolsHook(newHook, target)
     })
+    // clear buffer after 3s - the user probably doesn't have devtools installed
+    // at all, and keeping the buffer will cause memory leaks (#4738)
+    setTimeout(() => {
+      buffer = []
+    }, 3000)
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,11 @@ export function setDevtoolsHook(hook: DevtoolsHook, target: any) {`
`53`	`53`	`replay.push((newHook: DevtoolsHook) => {`
`54`	`54`	`setDevtoolsHook(newHook, target)`
`55`	`55`	`})`
	`56`	`+ // clear buffer after 3s - the user probably doesn't have devtools installed`
	`57`	`+ // at all, and keeping the buffer will cause memory leaks (#4738)`
	`58`	`+ setTimeout(() => {`
	`59`	`+ buffer = []`
	`60`	`+ }, 3000)`
`56`	`61`	`}`
`57`	`62`	`}`
`58`	`63`