Skip to content

Commit ecf872f

Browse files
authored
refactor(reactive): remove unnecessary args handling in reactiveEffect (#1593)
1 parent 22973b4 commit ecf872f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/reactivity/src/effect.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ type KeyToDepMap = Map<any, Dep>
1010
const targetMap = new WeakMap<any, KeyToDepMap>()
1111

1212
export interface ReactiveEffect<T = any> {
13-
(...args: any[]): T
13+
(): T
1414
_isEffect: true
1515
id: number
1616
active: boolean
@@ -77,20 +77,20 @@ export function stop(effect: ReactiveEffect) {
7777
let uid = 0
7878

7979
function createReactiveEffect<T = any>(
80-
fn: (...args: any[]) => T,
80+
fn: () => T,
8181
options: ReactiveEffectOptions
8282
): ReactiveEffect<T> {
83-
const effect = function reactiveEffect(...args: unknown[]): unknown {
83+
const effect = function reactiveEffect(): unknown {
8484
if (!effect.active) {
85-
return options.scheduler ? undefined : fn(...args)
85+
return options.scheduler ? undefined : fn()
8686
}
8787
if (!effectStack.includes(effect)) {
8888
cleanup(effect)
8989
try {
9090
enableTracking()
9191
effectStack.push(effect)
9292
activeEffect = effect
93-
return fn(...args)
93+
return fn()
9494
} finally {
9595
effectStack.pop()
9696
resetTracking()

0 commit comments

Comments
 (0)