Skip to content

Commit e8a866e

Browse files
committed
refactor(reactivity): remove stale API markReadonly
BREAKING CHANGE: `markReadonly` has been removed.
1 parent 9e9d264 commit e8a866e

File tree

4 files changed

+0
-24
lines changed

4 files changed

+0
-24
lines changed

packages/reactivity/__tests__/readonly.spec.ts

-12
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {
55
isReactive,
66
isReadonly,
77
markNonReactive,
8-
markReadonly,
98
lock,
109
unlock,
1110
effect,
@@ -424,17 +423,6 @@ describe('reactivity/readonly', () => {
424423
expect(isReactive(obj.bar)).toBe(false)
425424
})
426425

427-
test('markReadonly', () => {
428-
const obj = reactive({
429-
foo: { a: 1 },
430-
bar: markReadonly({ b: 2 })
431-
})
432-
expect(isReactive(obj.foo)).toBe(true)
433-
expect(isReactive(obj.bar)).toBe(true)
434-
expect(isReadonly(obj.foo)).toBe(false)
435-
expect(isReadonly(obj.bar)).toBe(true)
436-
})
437-
438426
test('should make ref readonly', () => {
439427
const n: any = readonly(ref(1))
440428
n.value = 2

packages/reactivity/src/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ export {
77
isReadonly,
88
shallowReadonly,
99
toRaw,
10-
markReadonly,
1110
markNonReactive
1211
} from './reactive'
1312
export {

packages/reactivity/src/reactive.ts

-10
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const readonlyToRaw = new WeakMap<any, any>()
2020

2121
// WeakSets for values that are marked readonly or non-reactive during
2222
// observable creation.
23-
const readonlyValues = new WeakSet<any>()
2423
const nonReactiveValues = new WeakSet<any>()
2524

2625
const collectionTypes = new Set<Function>([Set, Map, WeakMap, WeakSet])
@@ -47,10 +46,6 @@ export function reactive(target: object) {
4746
if (readonlyToRaw.has(target)) {
4847
return target
4948
}
50-
// target is explicitly marked as readonly by user
51-
if (readonlyValues.has(target)) {
52-
return readonly(target)
53-
}
5449
if (isRef(target)) {
5550
return target
5651
}
@@ -156,11 +151,6 @@ export function toRaw<T>(observed: T): T {
156151
return reactiveToRaw.get(observed) || readonlyToRaw.get(observed) || observed
157152
}
158153

159-
export function markReadonly<T>(value: T): T {
160-
readonlyValues.add(value)
161-
return value
162-
}
163-
164154
export function markNonReactive<T extends object>(value: T): T {
165155
nonReactiveValues.add(value)
166156
return value

packages/runtime-core/src/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ export {
1313
isReadonly,
1414
shallowReactive,
1515
toRaw,
16-
markReadonly,
1716
markNonReactive
1817
} from '@vue/reactivity'
1918
export { computed } from './apiComputed'

0 commit comments

Comments
 (0)